Added also linting and more rules to deal better with several platforms

.editorconfig

@@ -0,0 +1,15 @@
+root = true
+
+[*]
+end_of_line = lf
+insert_final_newline = true
+charset = utf-8
+trim_trailing_whitespace = true
+
+[*.{go,go.tmpl}]
+indent_style = tab
+indent_size = 4
+
+[*.{yaml,yml}]
+indent_style = space
+indent_size = 2

.gitattributes

@@ -0,0 +1,7 @@
+*.go   text eol=lf
+*.yaml text eol=lf
+*.yml  text eol=lf
+*.json text eol=lf
+*.sh   text eol=lf
+*.md   text eol=lf
+

.github/workflows/ci.yml

@@ -1,5 +1,4 @@
 name: Continuous Integration
-
 on:
   push:
 
@@ -13,7 +12,7 @@ jobs:
     name: Tests
     strategy:
       matrix:
-        os: [ ubuntu-latest ]
+        os: [ ubuntu-latest, windows-latest ]
     runs-on: ${{ matrix.os }}
     steps:
       - name: Install Go

.github/workflows/lint.yml

@@ -0,0 +1,28 @@
+name: Lint
+on:
+  push:
+
+  pull_request:
+    types:
+      - opened
+      - reopened
+
+permissions:
+  contents: read
+
+jobs:
+  golangci:
+    name: "golangci-lint"
+    strategy:
+      matrix:
+        os: [ ubuntu-latest, windows-latest ]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          go-version: stable
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v6
+        with:
+          version: v1.60

.golangci.yml

@@ -0,0 +1,30 @@
+run:
+  timeout: 20m
+
+linters:
+  enable:
+    - asasalint
+    - asciicheck
+    - bidichk
+    - misspell
+  disable:
+    - ineffassign
+
+linters-settings:
+  misspell:
+    locale: US
+    ignore-words:
+      - engity
+      - bifröst
+      - bifroest
+
+issues:
+  exclude-dirs:
+    - internal/fmtsort
+    - internal/text
+  exclude:
+    - S1002
+    - S1016
+    - SA1012
+    - S1031
+    - SA1019

cmd/bifroest/dummy-server.go

@@ -3,16 +3,18 @@ package main
 import (
 	"context"
 	"fmt"
-	"github.com/alecthomas/kingpin"
-	log "github.com/echocat/slf4g"
-	"github.com/engity-com/bifroest/pkg/common"
-	"github.com/engity-com/bifroest/pkg/errors"
 	"net"
 	"net/http"
 	"os"
 	"os/signal"
 	"strings"
 	"syscall"
+
+	"github.com/alecthomas/kingpin"
+	log "github.com/echocat/slf4g"
+
+	"github.com/engity-com/bifroest/pkg/common"
+	"github.com/engity-com/bifroest/pkg/errors"
 )
 
 var (
@@ -83,7 +85,7 @@ func dummyServerHandleIndex(w http.ResponseWriter, r *http.Request) {
 	if r.Method == http.MethodHead {
 		return
 	}
-	_, err = fmt.Fprintf(w, `Hello from a dummy-server!
+	_, _ = fmt.Fprintf(w, `Hello from a dummy-server!
 
 Called URI: %v
 Method:     %v

cmd/bifroest/sftp-server.go

@@ -1,9 +1,11 @@
 package main
 
 import (
+	"os"
+
 	"github.com/alecthomas/kingpin"
+
 	"github.com/engity-com/bifroest/pkg/sftp"
-	"os"
 )
 
 var (
@@ -53,7 +55,7 @@ func (this *stdpipe) Close() (rErr error) {
 		rErr = err
 	}
 	if err := os.Stdout.Close(); err != nil && rErr == nil {
-		rErr = err
+		rErr = err //nolint:golint,staticcheck
 	}
 	return nil
 }

cmd/bifroest/version.go

@@ -2,12 +2,14 @@ package main
 
 import (
 	"fmt"
-	"github.com/alecthomas/kingpin"
-	"github.com/engity-com/bifroest/pkg/common"
 	"os"
 	"runtime"
 	"strings"
 	"time"
+
+	"github.com/alecthomas/kingpin"
+
+	"github.com/engity-com/bifroest/pkg/common"
 )
 
 var (
@@ -95,9 +97,7 @@ func (this versionT) Vendor() string {
 }
 
 func (this versionT) GoVersion() string {
-	v := runtime.Version()
-	strings.TrimPrefix(v, "go")
-	return v
+	return strings.TrimPrefix(runtime.Version(), "go")
 }
 
 func (this versionT) Platform() string {

internal/text/template/exec_test.go

@@ -820,7 +820,7 @@ func testExecute(execTests []execTest, template *Template, t *testing.T) {
 				fmt.Printf("%s: %s\n\t%s\n", test.name, test.input, err)
 			}
 		}
-		result := b.String()
+		result := strings.ReplaceAll(b.String(), "\r\n", "\n")
 		if result != test.output {
 			t.Errorf("%s: expected\n\t%q\ngot\n\t%q", test.name, test.output, result)
 		}

pkg/authorization/authorization.go

@@ -2,11 +2,13 @@ package authorization
 
 import (
 	"context"
+
+	"golang.org/x/crypto/ssh"
+
 	"github.com/engity-com/bifroest/pkg/common"
 	"github.com/engity-com/bifroest/pkg/configuration"
 	"github.com/engity-com/bifroest/pkg/session"
 	"github.com/engity-com/bifroest/pkg/sys"
-	"golang.org/x/crypto/ssh"
 )
 
 type Authorization interface {

pkg/authorization/authorizer.go

@@ -3,9 +3,11 @@ package authorization
 import (
 	"context"
 	"errors"
+	"io"
+
 	log "github.com/echocat/slf4g"
+
 	"github.com/engity-com/bifroest/pkg/session"
-	"io"
 )
 
 var (

pkg/authorization/facade-authorizer.go

@@ -3,11 +3,12 @@ package authorization
 import (
 	"context"
 	"fmt"
+	"reflect"
+
 	"github.com/engity-com/bifroest/pkg/common"
 	"github.com/engity-com/bifroest/pkg/configuration"
 	"github.com/engity-com/bifroest/pkg/errors"
 	"github.com/engity-com/bifroest/pkg/session"
-	"reflect"
 )
 
 func NewAuthorizerFacade(ctx context.Context, flows *configuration.Flows) (*AuthorizerFacade, error) {

pkg/authorization/htpasswd-authorizer.go

@@ -4,7 +4,9 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
+
 	log "github.com/echocat/slf4g"
+
 	"github.com/engity-com/bifroest/pkg/configuration"
 	"github.com/engity-com/bifroest/pkg/errors"
 	"github.com/engity-com/bifroest/pkg/session"
@@ -244,10 +246,3 @@ func (this *HtpasswdAuthorizer) RestoreFromSession(ctx context.Context, sess ses
 func (this *HtpasswdAuthorizer) Close() error {
 	return nil
 }
-
-func (this *HtpasswdAuthorizer) logger() log.Logger {
-	if v := this.Logger; v != nil {
-		return v
-	}
-	return log.GetLogger("authorizer")
-}

pkg/authorization/htpasswd.go

@@ -3,11 +3,13 @@ package authorization
 import (
 	"context"
 	"fmt"
+
+	"golang.org/x/crypto/ssh"
+
 	"github.com/engity-com/bifroest/pkg/common"
 	"github.com/engity-com/bifroest/pkg/configuration"
 	"github.com/engity-com/bifroest/pkg/session"
 	"github.com/engity-com/bifroest/pkg/sys"
-	"golang.org/x/crypto/ssh"
 )
 
 type htpasswd struct {