Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite is going to be broken with Ruby 3.3 #190

Closed
voxik opened this issue Nov 28, 2023 · 1 comment · Fixed by #193
Closed

Test suite is going to be broken with Ruby 3.3 #190

voxik opened this issue Nov 28, 2023 · 1 comment · Fixed by #193

Comments

@voxik
Copy link
Contributor

voxik commented Nov 28, 2023 

$ rspec spec

An error occurred while loading ./spec/childprocess_spec.rb. - Did you mean?
                    rspec ./spec/spec_helper.rb

Failure/Error: require 'rubygems/mock_gem_ui'

LoadError:
  cannot load such file -- rubygems/mock_gem_ui
# ./spec/childprocess_spec.rb:4:in `<top (required)>'


Finished in 0.00003 seconds (files took 0.11016 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples

This is caused by:

rubygems/rubygems@eaa315b
ruby/ruby@7477284

I wish #178 / #182 landed soon to help address such issues.
@voxik voxik mentioned this issue Nov 28, 2023
Merged
4 tasks
@voxik
Copy link
Contributor Author

voxik commented Nov 28, 2023

One would thought that this could be simple to fix:

expect { gemspec.validate }.not_to output(/warn/i).to_stderr

But that is not the case unfortunately. Hopefully it will work in the future: rubygems/rubygems#7203

@voxik voxik mentioned this issue Dec 12, 2023
Merged
voxik added a commit to voxik/childprocess that referenced this issue Dec 20, 2023
@voxik
Make validates cleanly spec compatible with RubyGems 3.5+
b9d86b7 
`rubygems/mock_gem_ui` was removed in RubyGems 3.5+:

rubygems/rubygems#6623

Luckily, othe PR allowed to use standard RSpec methods for `$stdout`
testing:

rubygems/rubygems#7203

Fixes enkessler#190
voxik added a commit to voxik/childprocess that referenced this issue Dec 20, 2023
@voxik
Make validates cleanly spec compatible with RubyGems 3.5+
9742a0c 
`rubygems/mock_gem_ui` was removed in RubyGems 3.5+:

rubygems/rubygems#6623

Luckily, other PR allowed to use standard RSpec methods for `$stdout`
testing:

rubygems/rubygems#7203

Fixes enkessler#190
@voxik voxik mentioned this issue Dec 20, 2023
Merged
@sds sds closed this as completed in #193 Dec 21, 2023
sds pushed a commit that referenced this issue Dec 21, 2023
@voxik
Make validates cleanly spec compatible with RubyGems 3.5+ (#193)
9981cee 
`rubygems/mock_gem_ui` was removed in RubyGems 3.5+:

rubygems/rubygems#6623

Luckily, other PR allowed to use standard RSpec methods for `$stdout`
testing:

rubygems/rubygems#7203

Fixes #190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make validates cleanly spec compatible with RubyGems 3.5+ voxik/childprocess
1 participant
@voxik