Add GitHub Actions, fix Windows 3.1 & mswin #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSP-Greg
changed the title
|
Re the second point above, the error shown is I assumed that was a file error. I rewrote the test to use a UDP socket to pass the pid needed for the spec, and it still had the same error in Actions. But, as with the existing spec, the UDP version also passed locally on Windows 11 desktop. So, I'm not sure why it's failing on the Actions CI runners. |
8 tasks
mvz
added a commit
to cucumber/aruba
that referenced
this pull request
Dec 25, 2022
ChildProcess does not play nice with Ruby 3.1 build for Windows used in GitHub Actions. See enkessler/childprocess#182
chelnak
added a commit
to chelnak/childprocess
that referenced
this pull request
Mar 31, 2023
This commit updates msvcrt_name to return the value of RUBY_SO_NAME or ucrtbase. Change taken from enkessler#182.
sds
pushed a commit
that referenced
this pull request
Dec 13, 2023
This commit updates msvcrt_name to return the value of RUBY_SO_NAME or ucrtbase. Change taken from #182.
Closed
|
Thank you! Superseded by #175. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actions CI - similar to the code in PR Use GitHub Actions for CI testing #178, but only the workflow file. Updated Rubies, etc. Note that the coverage specific steps all failed with the other changes, so I added
if: falseto skip them for now.Added one skip. Frustrating. Sometimes Windows get squirrelly when a file is opened more than once, which the skipped spec does. But, running locally on Windows 11 and Ruby master, I could not repo the failure. Tried several things, and none fixed the CI failure. Maybe.later.
Publicly available Windows Rubies 2.4 thru 3.0 are all built with the MSYS2 mingw tool chain. Starting with Windows Ruby 3.1, builds are using the MSYS2 ucrt tool chain. The Windows fix only affects 3.1 and mswin builds.
Feel free to grab the Windows fix and add to PR #178.