Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions, fix Windows 3.1 & mswin #182

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
name: CI
on:
push:
pull_request:
workflow_dispatch:
# schedule:
# - cron: '0 0 1 * *' # Monthly

env:
CHILDPROCESS_UNSET: should-be-unset

jobs:
test:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
ruby: ['2.4', '2.5', '2.6', '2.7', '3.0', '3.1', head, jruby]
posix_spawn: [true, false]
include:
- { os: windows-latest, ruby: mswin, posix_spawn: true }
- { os: windows-latest, ruby: mswin, posix_spawn: false }
exclude:
# The action used seems to not fully support JRuby on Windows
- { os: windows-latest , ruby: jruby }

runs-on: ${{ matrix.os }}
env:
CHILDPROCESS_POSIX_SPAWN: ${{ matrix.posix_spawn }}
steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- name: Run Tests
run: bundle exec rake spec

- name: Push code coverage to Coveralls
if: false
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
path-to-lcov: "./coverage/lcov/lcov.info"
parallel: true
flag-name: run-${{ matrix.os }}-${{ matrix.ruby }}-${{ matrix.posix_spawn }}

test_finish:
needs: test
runs-on: ubuntu-latest
steps:
- name: Coveralls Finished
if: false
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
parallel-finished: true
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,4 @@ Gemfile.lock
.bundle

## PROJECT::SPECIFIC
vendor/bundle
37 changes: 0 additions & 37 deletions .travis.yml

This file was deleted.

36 changes: 0 additions & 36 deletions appveyor.yml

This file was deleted.

1 change: 1 addition & 0 deletions spec/childprocess_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@
end

it 'kills the full process tree', :process_builder => false do
skip "Windows 'Access is denied failure'?" if ChildProcess.windows?
Tempfile.open('kill-process-tree') do |file|
process = write_pid_in_sleepy_grand_child(file.path)
process.leader = true
Expand Down
Loading