Use PosixSpawnProcess instead of ForkExecProcess on platforms without fork #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fork * Such as on TruffleRuby, JRuby, etc. * ForkExecProcess does not work at all on these platforms anyway. * PosixSpawnProcess is not thread-safe with regard to the current working directory (oracle/truffleruby#1525 (comment)) but it's still better than failing with no fork. * enkessler#172 is the proper solution longer-term.
|
Dear maintainers of |
|
Sorry for the delay. Merged in #191. |
|
Thank you! BTW I'm interested in helping to maintain |
|
Would feel more comfortable if we had a working test suite using the efforts from your other PR, which is very close. Otherwise happy to include the changes in #175 in the next release if we can get all that put together. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this the test suite passes on TruffleRuby, except for 4 tests.
I don't feel great about the lack of thread-safety with
childprocess/lib/childprocess/unix/posix_spawn_process.rb
Line 43 in c005912
I would much prefer #175, but this may be easier to integrate shorter-term, and doesn't need a new major version bump.