Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions #192

Closed
wants to merge 3 commits into from
Closed

Add GitHub Actions #192

wants to merge 3 commits into from

Conversation

sds
Copy link
Collaborator

@sds sds commented Dec 13, 2023

Recreating #182 since GitHub UI would not allow me to resolve rebase conflicts.

@sds sds force-pushed the sds/github-actions branch from 9e288d2 to 88bf8dd Compare December 13, 2023 07:41
@eregon
Copy link
Contributor

eregon commented Dec 13, 2023

FYI there is a simple GitHub Actions workflow at https://github.com/enkessler/childprocess/pull/175/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f.

It seems best to avoid merging those Revert commits.

childprocess_spec.rb - skip 'kills the full process tree' on Windows

.gitignore - add vendor/bundle
Delete .travis.yml
Delete appveyor.yml
@sds sds force-pushed the sds/github-actions branch 2 times, most recently from 2efeb90 to 2c91f1b Compare December 20, 2023 07:54
@sds
Copy link
Collaborator Author

sds commented Dec 20, 2023

Going to close in favor of the work @eregon has done in #175.

@sds sds closed this Dec 20, 2023
@sds sds deleted the sds/github-actions branch December 20, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants