Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make validates cleanly spec compatible with RubyGems 3.5+ #193

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Make validates cleanly spec compatible with RubyGems 3.5+ #193

merged 1 commit into from
Dec 21, 2023
+9 −5

Conversation

voxik
Copy link
Contributor

@voxik voxik commented Dec 20, 2023

rubygems/mock_gem_ui was removed in RubyGems 3.5+:

rubygems/rubygems#6623

Luckily, other PR allowed to use standard RSpec methods for $stdout testing:

rubygems/rubygems#7203

Fixes #190

@voxik
Make validates cleanly spec compatible with RubyGems 3.5+
9742a0c 
`rubygems/mock_gem_ui` was removed in RubyGems 3.5+:

rubygems/rubygems#6623

Luckily, other PR allowed to use standard RSpec methods for `$stdout`
testing:

rubygems/rubygems#7203

Fixes enkessler#190
@voxik
Copy link
Contributor Author

voxik commented Dec 20, 2023

BTW I was also considering to try to require the rubygems/mock_gem_ui and branch based on the result. This would be more generic, but OTOH doing some test in rescue section would be awkward.

@sds sds merged commit 9981cee into enkessler:master Dec 21, 2023
1 check passed
@sds
Copy link
Collaborator

sds commented Dec 21, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test suite is going to be broken with Ruby 3.3
2 participants
@voxik @sds