Skip to content

Commit

Permalink
GUI adjustments around base velocity (LMMS#7196)
Browse files Browse the repository at this point in the history
Change the label of the group box from "CUSTOM BASE VELOCITY" to "VELOCITY MAPPING".

Remove the long explanation text from the group box and add the following tool tip for the LcdSpinBox: "MIDI notes at this velocity correspond to 100% note velocity."

Change the label of the spin box from "BASE VELOCITY" to "MIDI VELOCITY" because that's what the value actually represents.
  • Loading branch information
michaelgregorius authored and enp2s0 committed Apr 12, 2024
1 parent d06292e commit 92743d1
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions src/gui/instrument/InstrumentMidiIOView.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -144,23 +144,17 @@ InstrumentMidiIOView::InstrumentMidiIOView( QWidget* parent ) :
midiOutputLayout->insertWidget( 0, m_wpBtn );
}

auto baseVelocityGroupBox = new GroupBox(tr("CUSTOM BASE VELOCITY"));
auto baseVelocityGroupBox = new GroupBox(tr("VELOCITY MAPPING"));
baseVelocityGroupBox->setLedButtonShown(false);
layout->addWidget( baseVelocityGroupBox );

auto baseVelocityLayout = new QVBoxLayout(baseVelocityGroupBox);
baseVelocityLayout->setContentsMargins( 8, 18, 8, 8 );
baseVelocityLayout->setSpacing( 6 );

auto baseVelocityHelp
= new QLabel(tr("Specify the velocity normalization base for MIDI-based instruments at 100% note velocity."));
baseVelocityHelp->setWordWrap( true );
baseVelocityHelp->setFont(adjustedToPixelSize(baseVelocityHelp->font(), 10));

baseVelocityLayout->addWidget( baseVelocityHelp );

m_baseVelocitySpinBox = new LcdSpinBox( 3, baseVelocityGroupBox );
m_baseVelocitySpinBox->setLabel( tr( "BASE VELOCITY" ) );
m_baseVelocitySpinBox->setLabel(tr("MIDI VELOCITY"));
m_baseVelocitySpinBox->setToolTip(tr("MIDI notes at this velocity correspond to 100% note velocity."));
baseVelocityLayout->addWidget( m_baseVelocitySpinBox );

layout->addStretch();
Expand Down

0 comments on commit 92743d1

Please sign in to comment.