Call HasPrivateTraits.__init__() in GroupEditor.__init__ #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
pushed a commit
that referenced
this pull request
Jun 21, 2021
see #1674 modified: traitsui/qt4/ui_panel.py
|
still LGTM |
1 task
rahulporuri
pushed a commit
that referenced
this pull request
Jul 7, 2021
* FIX : Add missing call to __init__ in super class * FIX : Add missing call to __init__ in super class * FIX : Add missing call to __init__ in super class * FIX : Add missing call to super __init__ and fix a flake8 error modified: traitsui/editors/array_editor.py modified: traitsui/qt4/ui_panel.py * DEV : Undo change in qt4 GroupEditor see #1674 modified: traitsui/qt4/ui_panel.py * CLN : Pass args to __init__ call Previously, we were setting traits/attributes before calling __init__ on the objects, which setup the traits machinery. Instead, this commit passes the arguments to __init__, which feels like the right thing to do modified: traitsui/editors/array_editor.py modified: traitsui/editors/tuple_editor.py modified: traitsui/qt4/ui_panel.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1673
This PR takes the simpler quick fix approach as mentioned in this comment: #1673 (comment)
It is certainly worth the investigation into the alternate approach described in that comment. This was just a very simple fix that could be done in the short term
Checklist