Fix resetting of the error state for FileEditor #2007
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset the 'error' state of the file editor when its value changes. Previously, the state would remain
as error, which means the value cannot be set.
Created as draft because this only implements it for
wx
, whereasqt
has the same issue.The code block of the
_reset_error
functionis then present in four places:
text_editor
andfile_editor
for bothqt
andwx
. Since I'm not really familiar with the overall architecture of the code: What's the best place to put this? Or should I keep it separate?