Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NayNay] Entropy Faucet #133

Merged
merged 29 commits into from
Aug 28, 2024
Merged

[NayNay] Entropy Faucet #133

merged 29 commits into from
Aug 28, 2024

Conversation

rh0delta
Copy link
Contributor

@rh0delta rh0delta commented Jun 23, 2024 •
edited
Loading

@rh0delta please provide better descriptions in future prs! - @frankiebee

closes #28

rh0delta and others added 17 commits June 14, 2024 12:32
@rh0delta
wip: adding faucet to cli
c9d4ba9
@rh0delta
wip: got a signature back but ran into more issues post getting the s…
665c07c 
…ignature
@rh0delta
wip: got a sig and validated, but transaction is returning bad sig
ac2dc4a
@rh0delta
wip: manual sending of tx
968be83
@JesseAbram
fix
20d7637
@rh0delta
documentation
e5a9bae
@rh0delta
wip: new min amount for 1000e10 bits
971e20b
@rh0delta
clean up code; removing commented code not needed anymore
53d1dbf
@rh0delta
Merge branch 'dev' into naynay/faucet
4685ebe
@rh0delta
updating verifying key prop in sign request
c630168
@rh0delta
Merge branch 'dev' into naynay/faucet
d9e8787
@rh0delta
cleaned up faucet and added retry mechanism for failed faucets; added…
56d8652 
… logs as well
@rh0delta
more cleanup
a01cfe4
@rh0delta
updated error logging method to accept context
fc701f3
@rh0delta
remvoing export from method only used within singular file
d87682f
@rh0delta
updated sdk and removed cli installs of polkadot utils
416e497
@rh0delta
adding tests
7f35bd8
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@rh0delta
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@rh0delta
Copy link
Contributor Author

recheck

Entropy-Machine-CI added a commit to entropyxyz/.github that referenced this pull request Jul 26, 2024
@Entropy-Machine-CI
@rh0delta has signed the CLA in entropyxyz/cli#133
6cdbc1d
@JesseAbram
Copy link
Member

I have read the CLA Document and I hereby sign the CLA

@JesseAbram
Copy link
Member

recheck

Entropy-Machine-CI added a commit to entropyxyz/.github that referenced this pull request Jul 26, 2024
@Entropy-Machine-CI
@rh0delta has signed the CLA in entropyxyz/cli#133
315ad53
@mixmix
Copy link
Contributor

mixmix commented Jul 29, 2024

From team meeting:

naynay: last piece is getting test passing
file structure piece is more important

@frankiebee frankiebee added this to the [next] version 0.1.0 milestone Aug 20, 2024
@rh0delta rh0delta marked this pull request as ready for review August 23, 2024 00:46
frankiebee
frankiebee reviewed Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey bud.... you know this will have to match the new file structure... i guess i'll still merge it into dev and you can restructure after.

frankiebee
frankiebee requested changes Aug 26, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/common/logger.ts Outdated Show resolved Hide resolved
src/flows/entropyFaucet/constants.ts Outdated Show resolved Hide resolved
tests/faucet.test.ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document the flow of deploying a faucet in dev/README.md please

tests/faucet.test.ts Outdated Show resolved Hide resolved
rh0delta
rh0delta commented Aug 28, 2024
View reviewed changes
dev/README.md Outdated Show resolved Hide resolved
frankiebee
frankiebee requested changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to change and then all good!

src/flows/entropyFaucet/constants.ts Show resolved Hide resolved
src/flows/entropyFaucet/faucet.ts Outdated Show resolved Hide resolved
frankiebee
frankiebee approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks!

src/flows/entropyFaucet/faucet.ts Show resolved Hide resolved
@rh0delta @frankiebee
Update src/flows/entropyFaucet/constants.ts
d39622a 
Co-authored-by: Frankie <frankie.diamond@gmail.com>
@rh0delta rh0delta linked an issue Aug 28, 2024 that may be closed by this pull request
faucet #28
Closed
@rh0delta rh0delta merged commit 3a3130f into dev Aug 28, 2024
2 checks passed
@rh0delta rh0delta deleted the naynay/faucet branch August 28, 2024 21:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frankiebee frankiebee frankiebee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
[next] version 0.1.0
Development

Successfully merging this pull request may close these issues.

faucet
4 participants
@rh0delta @JesseAbram @mixmix @frankiebee