add deploy to CLI, including start of CLI refactor #213
Conversation
mixmix
force-pushed
the
mixmix/deploy_cli
branch
from
9698d82
to
0a7be2d
Compare
|
@rh0delta I reckon the pattern here for cli could really help split out the tui/cli clutter. |
Yeah i agree, i do like the degree of separation here, but will this be the same as how we want to handle the tui as well? |
|
I'm not sure how the TUI will end up.... |
|
TODO:
|
…nto mixmix/deploy_cli
mixmix
force-pushed
the
mixmix/deploy_cli
branch
from
5bdfccf
to
2b1160b
Compare
|
Hey @rh0delta can I have a re-review? Through some closer looking I discovered that |
How was it that config.init was never called? really curious about this. I thought we had it initialized at the same point as initializing wasm. |
mixmix
changed the base branch from
naynay/file-restructure
to
mixmix/fix-config
|
Yeah I don't know what happened! I assume it just got lost in the refactoring. |
| // .addCommand(entropyProgramGet()) | ||
| // .addCommand(entropyProgramListDeployed()) | ||
| // .addCommand(entropyProgramAdd()) | ||
| // .addCommand(entropyProgramRemove()) | ||
| // .addCommand(entropyProgramList()) |
There was a problem hiding this comment.
I wanna do these in a different PR. Maybe even after we do a new release.
This is "feature completeness", not "refactor"
| async get (programPointer: string): Promise<any> { | ||
| this.logger.debug(`program pointer: ${programPointer}`, `${FLOW_CONTEXT}::PROGRAM_PRESENCE_CHECK`); | ||
| return this.entropy.programs.dev.getProgramInfo(programPointer) | ||
| } | ||
|
|
||
| async listDeployed () { | ||
| const address = this.entropy.keyring.accounts.registration.address | ||
| // QUESTION: will we always be wanting this address? | ||
| return this.entropy.programs.dev.get(address) | ||
| } |
There was a problem hiding this comment.
NOTE: I think these are about to change with the next SDK release (just reviewing these)
This adds deploy to the CLI
This PR also start to add a new pattern for how to CLI which is "one file per major command"
It shows how we're gonna do subcommands too
CHANGELOG.mdentry.github.com:entropyxyz/entropy-docs, where necessary.