[NayNay] Removing Mention of Password #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #239 - removed use of passowrd from account main and command - removed use of password from balance command - removed use of password from old flows directory
rh0delta
changed the title
rh0delta
added
documentation
|
@rh0delta question for me here is "how sure are we that this isn't coming back?" |
I believe the intention here is to remove any mention/use of password encryption from the legacy interface. We have another issue (#240) that is intended to track our discussions and design sessions for the new encryption flow. |
|
Blocked until entropyxyz/entropy-docs#239 is out of draft-mode. |
|
Aaaaand entropyxyz/entropy-docs#239 is ready to merge. This PR is no longer blocked by docs. |
johnnymatthews
approved these changes
Oct 15, 2024
|
Sure, I'll approve, we can time-travel! |
mixmix
approved these changes
Oct 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Proposed Changes
Testing
Screenshots (if applicable)
Additional Context
Checklist
CHANGELOG.mdentry.github.com:entropyxyz/entropy-docs, where necessary.