-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NayNay] Removing Mention of Password #252
Conversation
resolves #239 - removed use of passowrd from account main and command - removed use of password from balance command - removed use of password from old flows directory
@rh0delta question for me here is "how sure are we that this isn't coming back?" |
I believe the intention here is to remove any mention/use of password encryption from the legacy interface. We have another issue (#240) that is intended to track our discussions and design sessions for the new encryption flow. |
Blocked until entropyxyz/entropy-docs#239 is out of draft-mode. |
Aaaaand entropyxyz/entropy-docs#239 is ready to merge. This PR is no longer blocked by docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from where I'm stood. But get an engineer to approve this before merging.
Sure, I'll approve, we can time-travel! |
Related Issue(s)
Proposed Changes
Testing
Screenshots (if applicable)
Additional Context
Checklist
CHANGELOG.md
entry.github.com:entropyxyz/entropy-docs
, where necessary.