Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Updates token to bit/s where necessary. #266

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] Updates token to bit/s where necessary. #266

wants to merge 3 commits into from

Conversation

johnnymatthews
Copy link
Collaborator

Closes #265

@johnnymatthews johnnymatthews self-assigned this Nov 18, 2024
@johnnymatthews johnnymatthews added the blocked This issue cannot be completed as it depends on another open issue. label Nov 18, 2024
@johnnymatthews
Copy link
Collaborator Author

Marking as blocked until the JS team does their release magic.

@johnnymatthews johnnymatthews changed the title Updates token to bit/s where necessary. [DO NOT MERGE] Updates token to bit/s where necessary. Nov 18, 2024
@johnnymatthews
Copy link
Collaborator Author

Tagged @frankiebee @mixmix and @rh0delta for a review. Only really need a single review from someone though; all three is overkill for such a small PR.

mixmix
mixmix requested changes Dec 3, 2024
View reviewed changes
Copy link

@mixmix mixmix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested change

  • consistent capitalisation
    • BITS not bits
    • nanoBITS not nanobits

Recommended to consider

  • do we singularise or are we always plural units? i.e. is BIT a thing?
  • we may be changing from nanoBITS to lilBITS
    • hmm lilBITS is pretty hard to read. maybe we defer that

content/basics/glossary.md Outdated Show resolved Hide resolved
@johnnymatthews johnnymatthews requested a review from mixmix December 4, 2024 13:56
@johnnymatthews johnnymatthews mentioned this pull request Dec 11, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankiebee frankiebee Awaiting requested review from frankiebee

@rh0delta rh0delta Awaiting requested review from rh0delta

@mixmix mixmix Awaiting requested review from mixmix

Requested changes must be addressed to merge this pull request.

Assignees

@johnnymatthews johnnymatthews

Labels
blocked This issue cannot be completed as it depends on another open issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update token units to match CLI update.
2 participants
@johnnymatthews @mixmix