ISSUE#405 dev programs rework #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the type interface of ProgramInstance for registration
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
|
frankiebee
changed the title
Entropy-Machine-CI
added a commit
to entropyxyz/.github
that referenced
this pull request
Aug 6, 2024
frankiebee
changed the title
mixmix
reviewed
Aug 20, 2024
mixmix
requested changes
Aug 20, 2024
What test is failing? |
|
The one in this comment - #409 (comment) |
|
ahh missed that in the comment. |
Co-authored-by: mix irving <mix@protozoa.nz>
mixmix
requested changes
Sep 24, 2024
| * @property {ArrayBuffer} bytecode - The bytecode of the program. | ||
| * @property {unknown} [interfaceDescription] - Optional. The configuration interface of the program. | ||
| * @property {string} deployer - The address of the deployer of the program. | ||
| * @property {number} refCounter - The reference count for the program. | ||
| */ | ||
|
|
||
| // interfaceDescription needs better design and another type other than 'unknown' | ||
| export interface ProgramInfo { | ||
| export interface ProgramInterface { |
There was a problem hiding this comment.
before release, lets see if we can get this exported for use in CLI / other apps
Co-authored-by: mix irving <mix@protozoa.nz>
Co-authored-by: mix irving <mix@protozoa.nz>
…o frankie/i#405programs
mixmix
reviewed
Sep 25, 2024
mixmix
approved these changes
Oct 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes #405
Testing
Checklist