fix(routing): Fix filter and board sorting performance #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purusott
requested review from
oyvindgrutle,
emilielr and
lindtvedtsebastian
and removed request for
lindtvedtsebastian
emilielr
requested changes
Jul 4, 2024
purusott
force-pushed
the
fix-filter-performance
branch
from
1a53b28
to
1d8c627
Compare
purusott
requested review from
emilielr
and removed request for
lindtvedtsebastian
emilielr
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slow filter caused by NextJS routing
router.replace()behaved slow to update the browsers history stack (tested with React profiler), so the main solution was to use the alternative history API to fix the performance issues.This also makes sorting in /boards faster compared to before
Also did some refactoring in
Filterbuttonandpage