Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(landing): contact form #1636
base: master
Are you sure you want to change the base?
feat(landing): contact form #1636
Changes from all commits
18f0adc
e914ba7
7de9da9
134013c
763e070
ba47755
0c501d1
613f26d
b7f8c15
aac57ba
4660f7c
1c20e45
4687709
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Synes det virker litt rart å legge til en error-handling for å resette en form. Vi burde finne en annen løsning. Jeg tittet litt rundt, kanskje vi kan legge til et ekstra felt som heter "success"? Litt som de gjør her: https://react.dev/reference/react/useActionState#display-information-after-submitting-a-form
Vi kan sette oss ned å gjøre denne sammen tenker jeg:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kan man flytte all denne valideringen til server-siden?
Da tror jeg kanskje vi kan eliminere setFormError helt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Det skjer i server også, så kan i prinsippet fjerne det helt. Tenkte bare det blir dårlig UX å validere bare i server (selv om det er viktigere der) mtp nettverkskall og latency.
Et alternativ er å bruke html sin innebygde validering. Da blir feilmeldingene på engelsk med mindre vi overstyrer med userefs
Men hvis vi kun ønsker server validering kan jeg fjerne usestate greiene :)
This file was deleted.