Ext proc http functionality support #35740

yanjunxiang-google · 2024-08-18T14:14:03Z

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes:

Description:
This is to address the issue: #35488, i.e, integrate the ext_proc HTTP client to ext_proc filter. With this PR, the basic functionalities to have Envoy ext_proc filter talk to a HTTP server using HTTP messages are accomplished.

This is the follow up of PR: #35676

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

…roc_http_client Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

yanjunxiang-google · 2024-08-22T19:24:59Z

This PR adds the support of sending ext_proc call out messages to the HTTP side stream server. The proto messages: ProcessingRequest/ProcessingResponse are transcoded into JSON text and encoded in the body of a HTTP message.

The processing flow works this way:

When Envoy needs to send call out messages to the side stream server, either header, body , or trailer, Envoy construct a ProcessingRequest proto message.
This ProcessingRequest message is transcoded into a JSON text. This JSON text is then added as a body to a HTTP "POST" message. This HTTP message is sent to the side stream HTTP server.
The HTTP server receives the "POST" message. Transcoding the body, i.e, a JSON text, into a ProcessingRequest message.
The HTTP server then performs normal header/body/trailer mutation as existing, and put them into a ProcessingResponse proto message.
The HTTP server then transcode the ProcessingResponse into JSON text, and sends back a 200 response with this JSON text as body.
After receives the 200 response, Envoy then convert the body from JSON text back to a ProcessingResponse proto message. Then continue processing this ProcessingResponse.

Overall, the ext_proc gRPC and HTTP share identical state machine and logic. The only difference is in the message sending mechanism. One using gRPC, and the ProcessingRequest/ProcessingResponse messages are sent as proto messages. The other sends messages using HTTP, with the ProcessingRequest/ProcessingResponse proto messages are transcoded into JSON text, and encoded as the body in the HTTP messages.

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

yanjunxiang-google · 2024-09-27T11:45:34Z

/retest

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

…roc_http_integration Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

yanjunxiang-google · 2024-09-27T14:05:04Z

/docs

repokitteh-read-only · 2024-09-27T14:05:09Z

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/35740/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #35740 (comment) was created by @yanjunxiang-google.

see: more, trace.

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

yanjunxiang-google · 2024-09-27T16:37:37Z

@envoyproxy/api-shepherds PTAL and approve

adisuissa

Thanks!
Let's make this unimplemented-hide and make it under work-in-progress so this can be tested properly and finalized later.

api/envoy/extensions/filters/http/ext_proc/v3/ext_proc.proto

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

adisuissa

/lgtm api

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

source/extensions/filters/http/ext_proc/http_client/http_client_impl.cc

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

yanjunxiang-google · 2024-09-30T13:47:37Z

/retest

yanjunxiang-google · 2024-09-30T14:25:19Z

Kind Ping!

yanavlasov

/wait

source/extensions/filters/http/ext_proc/client_impl.cc

yanjunxiang-google added 15 commits July 30, 2024 03:12

Adding HTTP service support for Envoy external processing

28094b9

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

adding not-implemented-hide

b0c2271

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

addressing comments

592c1e1

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

change the proto field name

e22aa8c

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

fix format error

a017259

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

addressing comments

7e0a578

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

Merge branch 'main' of https://github.com/envoyproxy/envoy into ext_p…

6d3097f

…roc_http_client Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

Adding HTTP client for the ext_proc filter

dad36f0

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

adding http_client

d3e1577

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

adding HTTP client framework

c9c2b22

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

moving client_base to http_client directory

0fcb348

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

adding the http_client unit-test framework

f8b793a

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

fix format

dadad62

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

fix testing issue

72d82bb

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

Integrate HTTP client to ext_proc filter

b787a76

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

yanjunxiang-google requested review from tyxia, mattklein123, htuch and yanavlasov as code owners August 18, 2024 14:14

yanjunxiang-google marked this pull request as draft August 18, 2024 14:14

yanjunxiang-google added 8 commits August 18, 2024 14:22

merge upstream main

e964444

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

refactor the base client class inheritance

bcedfd9

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

getting the basic functionality working

6f2e962

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

adding integration test

3798f28

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

revert changes in ext_proc_integration_test.cc

a93234a

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

adding integration tests

00d56fc

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

fix format

26df644

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

adding onError, cancel support

4aee4be

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

fixing tests

a08e5ad

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

yanjunxiang-google added 5 commits September 26, 2024 19:25

moving client_base.h into up level

9bb769e

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

fix format

19c494d

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

set callbacks in client

e54c16f

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

fix CI issue

613001a

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

delete wrong file

e52291e

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

yanjunxiang-google added 3 commits September 27, 2024 12:12

removing unused runtime

5514193

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

Merge branch 'main' of https://github.com/envoyproxy/envoy into ext_p…

bf515cf

…roc_http_integration Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

removing size in BUILD

5c23475

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

adding rbe_pool

d190cbe

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

adisuissa reviewed Sep 27, 2024

View reviewed changes

yanjunxiang-google added 2 commits September 27, 2024 18:45

addressing API comments

3ffd9e7

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

adding proto import package

f9f13ce

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

adisuissa reviewed Sep 27, 2024

View reviewed changes

repokitteh-read-only bot removed the api label Sep 27, 2024

yanjunxiang-google added 2 commits September 28, 2024 05:09

adding cancel() in ClientBase

038c6d7

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

addressing comments

5ffb042

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

jmarantz reviewed Sep 28, 2024

View reviewed changes

source/extensions/filters/http/ext_proc/http_client/http_client_impl.cc Outdated Show resolved Hide resolved

yanjunxiang-google added 2 commits September 28, 2024 17:47

refactor out request message building code

82f63c5

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

addressing comments

8552778

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

yanavlasov requested changes Sep 30, 2024

View reviewed changes

source/extensions/filters/http/ext_proc/client_impl.cc Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Sep 30, 2024

yanavlasov approved these changes Sep 30, 2024

View reviewed changes

yanavlasov merged commit a3e32c9 into envoyproxy:main Sep 30, 2024
21 checks passed

yanjunxiang-google deleted the ext_proc_http_integration branch October 2, 2024 21:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ext proc http functionality support #35740

Ext proc http functionality support #35740

yanjunxiang-google commented Aug 18, 2024 •

edited

Loading

yanjunxiang-google commented Aug 22, 2024 •

edited

Loading

yanjunxiang-google commented Sep 27, 2024

yanjunxiang-google commented Sep 27, 2024

repokitteh-read-only bot commented Sep 27, 2024

yanjunxiang-google commented Sep 27, 2024

adisuissa left a comment

adisuissa left a comment

yanjunxiang-google commented Sep 30, 2024

yanjunxiang-google commented Sep 30, 2024

yanavlasov left a comment

Ext proc http functionality support #35740

Ext proc http functionality support #35740

Conversation

yanjunxiang-google commented Aug 18, 2024 • edited Loading

yanjunxiang-google commented Aug 22, 2024 • edited Loading

yanjunxiang-google commented Sep 27, 2024

yanjunxiang-google commented Sep 27, 2024

repokitteh-read-only bot commented Sep 27, 2024

yanjunxiang-google commented Sep 27, 2024

adisuissa left a comment

Choose a reason for hiding this comment

adisuissa left a comment

Choose a reason for hiding this comment

yanjunxiang-google commented Sep 30, 2024

yanjunxiang-google commented Sep 30, 2024

yanavlasov left a comment

Choose a reason for hiding this comment

yanjunxiang-google commented Aug 18, 2024 •

edited

Loading

yanjunxiang-google commented Aug 22, 2024 •

edited

Loading