http2: improve coordination between StreamResetReason and HTTP2 RST_STREAM error codes #36203
CI (Envoy) / Envoy/macOS
succeeded
Sep 20, 2024 in 28m 50s
Envoy/macOS (success)
Check has finished
Details
Check run finished (success ✔️)
The check run can be viewed here:
Envoy/macOS (pr/36203/main@8848ce7)
Check started by
Request (pr/36203/main@8848ce7)
8848ce7 
#36203 merge main@d6120f3
http2: improve coordination between StreamResetReason and HTTP2 RST_STREAM error codes
Commit Message: http2: improve coordination between StreamResetReason and HTTP2 RST_STREAM error codes
Additional Description: See linked issue. This PR makes locally-originated resets use more reasonable HTTP2 error codes, especially focusing on not using NO_ERROR where inappropriate. It also improves the translation of HTTP2 error codes into StreamResetReasons for remote-originated HTTP2 resets. An integration test is included which tests the scenario outlined in the linked issue.
Risk Level: medium. this may change behavior for existing http2 clients.
Testing: included, may need more (?)
Docs Changes: n/a
Release Notes: included
Fixes #36200
Environment
Request variables
| Key | Value |
|---|---|
| ref | 53b23fd |
| sha | 8848ce7 |
| pr | 36203 |
| base-sha | d6120f3 |
| actor | @AdamEAnderson |
| message | http2: improve coordination between StreamResetReason and HTTP2 RST_STREAM error codes... |
| started | 1726800934.712943 |
| target-branch | main |
| trusted | false |
Build image
Container image/s (as used in this CI run)
| Key | Value |
|---|---|
| default | envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
| mobile | envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
Version
Envoy version (as used in this CI run)
| Key | Value |
|---|---|
| major | 1 |
| minor | 32 |
| patch | 0 |
| dev | true |
Loading