Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump grpc-httpjson-transcoding #36229

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

asedeno
Copy link
Contributor

@asedeno asedeno commented Sep 19, 2024

Updating to a version which is more amenable to future protobuf updates.

Risk Level: low
Testing:

$ bazel test                                                \
//test/extensions/filters/http/grpc_json_transcoder/...     \
//test/extensions/filters/http/grpc_field_extraction/...    \
//test/extensions/filters/http/proto_message_extraction/...

Signed-off-by: Alejandro R Sedeño <asedeno@google.com>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #36229 was opened by asedeno.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 19, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #36229 was opened by asedeno.

see: more, trace.

@asedeno
Copy link
Contributor Author

asedeno commented Sep 19, 2024

Carving off more of #36167; this is a new upstream version of grpc-httpjson-transcoding with the series of eight patches I was testing merged in.

@asedeno
Copy link
Contributor Author

asedeno commented Sep 19, 2024

/retest

@asedeno asedeno marked this pull request as ready for review September 19, 2024 21:31
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @asedeno

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Sep 20, 2024
@phlax phlax enabled auto-merge (squash) September 20, 2024 20:53
@asedeno
Copy link
Contributor Author

asedeno commented Sep 20, 2024

/retest

@phlax phlax merged commit f575d26 into envoyproxy:main Sep 20, 2024
39 of 40 checks passed
@asedeno asedeno deleted the update-grpc-httpjson-transcoding branch October 7, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants