-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamic_modules: switch to crate_universe to remove manual bindgen #36240
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
cc @phlax - i am trying to enable crate_universe here which I think doesn't work for gcc and compiletime_options jobs. let's see |
so crate_universe itself seems to be working. The next is to see whether the bindgen actually works or not |
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
i think it's all good now 🤞 |
Commit Message: dynamic_modules: switch to crate_universe to remove manual bindgen
Additional Description:
This is a follow up on #35914 which ended up requiring a manual
step to generate the binding for the ABI headers.
This switches to use crate_universe and use the bindgen as a dev-dependency.
As a result, we can adopt the build.rs script to generate the C bindings at build
time instead of the manual bindgen step.
This also allows us to freely add a crate dependency when it becomes necessary.
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]