Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bp/1.29] repo: Separate examples to their own repo #36266

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

phlax
Copy link
Member

@phlax phlax commented Sep 20, 2024

No description provided.

Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
@phlax phlax enabled auto-merge (rebase) September 20, 2024 16:34
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 20, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #36266 was synchronize by phlax.

see: more, trace.

phlax and others added 2 commits September 20, 2024 20:09
fix envoyproxy#32737

---------

Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
see also envoyproxy#32737 and
envoyproxy#32737 (comment),

Commit Message: update git repo url in docs to refer to the new examples
repo
Additional Description: might fix docs
Risk Level: none
Testing: none
Docs Changes: changes docs/root/start/sandboxes/setup.rst to refer to
the right github repo (examples)

---------

Signed-off-by: David Goodwin <david@codepoets.co.uk>
Signed-off-by: Ryan Northey <ryan@synca.io>
@moderation
Copy link
Contributor

/lgtm deps

Copy link

🙀 Error while processing event:

evaluation error
error: signaled
🐱

Caused by: a #36266 (comment) was created by @moderation.

see: more, trace.

@phlax phlax merged commit 7cecb9f into envoyproxy:release/v1.29 Sep 23, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants