Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext_proc: Add allow list for mode override #36279

Merged
merged 7 commits into from
Sep 24, 2024
Merged

ext_proc: Add allow list for mode override #36279

merged 7 commits into from
Sep 24, 2024

Conversation

tyxia
Copy link
Member

@tyxia tyxia commented Sep 22, 2024 •
edited
Loading

Added allow list allowed_override_modes for mode_override.
Risk Level: LOW
Testing: Integration test
Docs Changes: N/A
Release Notes: Yes
Platform Specific Features: N/A

@tyxia
ext_proc: Add allow list for mode override
726f0c8 
Signed-off-by: tyxia <tyxia@google.com>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #36279 was opened by tyxia.

see: more, trace.

@repokitteh-read-only RepoKitteh - Read Only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #36279 was opened by tyxia.

see: more, trace.

@tyxia
fix format
ca8ad1e 
Signed-off-by: tyxia <tyxia@google.com>
@tyxia
fix typo
744dfd1 
Signed-off-by: tyxia <tyxia@google.com>
@tyxia
fix format
859b60d 
Signed-off-by: tyxia <tyxia@google.com>
@tyxia
fix format
c84ae94 
Signed-off-by: tyxia <tyxia@google.com>
@tyxia
fix typo
db21935 
Signed-off-by: tyxia <tyxia@google.com>
@tyxia
Merge branch 'main' of https://github.com/envoyproxy/envoy into ext_p…
da714f3 
…roc_mode_override

Signed-off-by: tyxia <tyxia@google.com>
@tyxia tyxia marked this pull request as ready for review September 23, 2024 14:17
@tyxia
Copy link
Member Author

tyxia commented Sep 23, 2024

/assign @yanavlasov @rshriram @htuch

@mattklein123
Copy link
Member

/api lgtm

@yanavlasov yanavlasov merged commit d741737 into envoyproxy:main Sep 24, 2024
39 of 40 checks passed
@tyxia tyxia deleted the ext_proc_mode_override branch September 24, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanavlasov yanavlasov yanavlasov approved these changes

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

Assignees

@mattklein123 mattklein123

@yanavlasov yanavlasov

@rshriram rshriram

@htuch htuch

Labels
api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tyxia @mattklein123 @yanavlasov @rshriram @htuch