Skip to content

Commit

Permalink
DB Client (#21)
Browse files Browse the repository at this point in the history
* add psql, user, and basic database actions, and reformat

* as sudo

* and apt update

* try again

* add apt get?

* again

* sudo tee

* try just postgres

* corrections to actions yaml

* back to 22

* update workflow for revising the database from the models and using alembic to autogen revisions

* fix version ref

* try to update

* fix unit tests -- i think

* add basic tests

* path, not string

* unit tests fixed
  • Loading branch information
SerRichard authored Mar 4, 2024
1 parent 8a35e92 commit c7dea5c
Show file tree
Hide file tree
Showing 17 changed files with 471 additions and 4 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ jobs:
with:
submodules: recursive

- name: Install Postgresql 15 for unit tests
id: install-postgres-15
run: |
sudo apt-get update -qy && \
sudo apt install -qy postgresql
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
Expand All @@ -62,7 +68,7 @@ jobs:
run: poetry run pre-commit run

- name: Run pytest
run: poetry run pytest --cov=openeo_processes_dask --cov-report=xml
run: poetry run pytest --cov=openeo-fastapi --cov-report=xml

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ coverage.xml
.hypothesis/
.pytest_cache/
cover/
tests/__pycache__

# Translations
*.mo
Expand Down Expand Up @@ -163,4 +164,4 @@ cython_debug/

notebooks/
.notebooks/
poetry.lock
poetry.lock
30 changes: 30 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,36 @@

A FastAPI implementation of the OpenEO Api specification.

## Install

Install using pip
```
```

### Use

The openeo fastapi repo has been set up to work with alembic. When you use this package to to prepare your api, you will need to create an alembic directory. In this directory, you can optionally add a models.py file and extend and of the models from openeo_fastapi.client.models.

The env.py file in the alembic directory, needs to be edited in the following way.
```
from openeo_fastapi.settings import BASE
target_metadata = BASE.metadata
```

You can now create auto revisions for a psql database using the alembic python commands.

```
alembic_cfg = Config("alembic.ini")
command.revision(alembic_cfg, f"openeo-fastapi-{__version__}", autogenerate=True)
command.upgrade(alembic_cfg, "head")
engine = get_engine()
```

Check how it is configured for the tests to see more.

## Contribute

Included is a vscode dev container which is intended to be used as the development environment for this package. A virtual environment needs to be set up inside the dev container, this is managed by poetry.
Expand Down
Empty file.
19 changes: 19 additions & 0 deletions openeo_fastapi/client/psql/engine.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
from sqlalchemy import create_engine

from openeo_fastapi.client.psql.settings import BASE, DataBaseSettings


def get_engine():
"""Return default session using config from pydantic settings."""
db_settings = DataBaseSettings()

engine = create_engine(
url="postgresql://{}:{}@{}:{}/{}".format(
db_settings.POSTGRES_USER._secret_value,
db_settings.POSTGRES_PASSWORD._secret_value,
db_settings.POSTGRESQL_HOST._secret_value,
db_settings.POSTGRESQL_PORT._secret_value,
db_settings.POSTGRES_DB._secret_value,
)
)
return engine
17 changes: 17 additions & 0 deletions openeo_fastapi/client/psql/models.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import datetime

from sqlalchemy import VARCHAR, Column, DateTime
from sqlalchemy.dialects.postgresql import UUID

from openeo_fastapi.client.psql.settings import BASE


class User(BASE):
"""ORM for the user table."""

__tablename__ = "users"
__table_args__ = {"extend_existing": True}

user_id = Column(UUID(as_uuid=True), primary_key=True, unique=True)
oidc_sub = Column(VARCHAR, unique=True)
created_at = Column(DateTime, default=datetime.datetime.utcnow(), nullable=False)
16 changes: 16 additions & 0 deletions openeo_fastapi/client/psql/settings.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
from pathlib import Path

from pydantic import BaseSettings, SecretStr
from sqlalchemy.orm import declarative_base

BASE = declarative_base()


class DataBaseSettings(BaseSettings):
POSTGRES_USER: SecretStr
POSTGRES_PASSWORD: SecretStr
POSTGRESQL_HOST: SecretStr
POSTGRESQL_PORT: SecretStr
POSTGRES_DB: SecretStr

ALEMBIC_DIR: Path
5 changes: 4 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ planetary_computer = ">=1.0.0"
stackstac = ">=0.5.0"
stac-validator = ">=3.3.2"
pip = "^23.3.2"
ipykernel = "^6.28.0"
requests = "^2.31.0"
SQLAlchemy = "^2.0.27"
psycopg2-binary = "^2.9.5"
alembic = "^1.13.1"

[tool.poetry.group.dev.dependencies]
pytest = "^7.2.0"
Expand All @@ -34,6 +36,7 @@ pre-commit = "^2.20.0"
pytest-cov = "^4.0.0"
pytest-asyncio = "^0.23.0"
aioresponses = "^0.7.5"
pytest-postgresql = ">=4.1.1"

[build-system]
requires = ["poetry-core"]
Expand Down
Empty file added tests/alembic/README.md
Empty file.
116 changes: 116 additions & 0 deletions tests/alembic/alembic.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
# A generic, single database configuration.

[alembic]
# path to migration scripts
script_location = alembic

# template used to generate migration file names; The default value is %%(rev)s_%%(slug)s
# Uncomment the line below if you want the files to be prepended with date and time
# see https://alembic.sqlalchemy.org/en/latest/tutorial.html#editing-the-ini-file
# for all available tokens
# file_template = %%(year)d_%%(month).2d_%%(day).2d_%%(hour).2d%%(minute).2d-%%(rev)s_%%(slug)s

# sys.path path, will be prepended to sys.path if present.
# defaults to the current working directory.
prepend_sys_path = .

# timezone to use when rendering the date within the migration file
# as well as the filename.
# If specified, requires the python>=3.9 or backports.zoneinfo library.
# Any required deps can installed by adding `alembic[tz]` to the pip requirements
# string value is passed to ZoneInfo()
# leave blank for localtime
# timezone =

# max length of characters to apply to the
# "slug" field
# truncate_slug_length = 40

# set to 'true' to run the environment during
# the 'revision' command, regardless of autogenerate
# revision_environment = false

# set to 'true' to allow .pyc and .pyo files without
# a source .py file to be detected as revisions in the
# versions/ directory
# sourceless = false

# version location specification; This defaults
# to alembic/versions. When using multiple version
# directories, initial revisions must be specified with --version-path.
# The path separator used here should be the separator specified by "version_path_separator" below.
# version_locations = %(here)s/bar:%(here)s/bat:alembic/versions

# version path separator; As mentioned above, this is the character used to split
# version_locations. The default within new alembic.ini files is "os", which uses os.pathsep.
# If this key is omitted entirely, it falls back to the legacy behavior of splitting on spaces and/or commas.
# Valid values for version_path_separator are:
#
# version_path_separator = :
# version_path_separator = ;
# version_path_separator = space
version_path_separator = os # Use os.pathsep. Default configuration used for new projects.

# set to 'true' to search source files recursively
# in each "version_locations" directory
# new in Alembic version 1.10
# recursive_version_locations = false

# the output encoding used when revision files
# are written from script.py.mako
# output_encoding = utf-8

sqlalchemy.url = driver://user:pass@localhost/dbname


[post_write_hooks]
# post_write_hooks defines scripts or Python functions that are run
# on newly generated revision scripts. See the documentation for further
# detail and examples

# format using "black" - use the console_scripts runner, against the "black" entrypoint
# hooks = black
# black.type = console_scripts
# black.entrypoint = black
# black.options = -l 79 REVISION_SCRIPT_FILENAME

# lint with attempts to fix using "ruff" - use the exec runner, execute a binary
# hooks = ruff
# ruff.type = exec
# ruff.executable = %(here)s/.venv/bin/ruff
# ruff.options = --fix REVISION_SCRIPT_FILENAME

# Logging configuration
[loggers]
keys = root,sqlalchemy,alembic

[handlers]
keys = console

[formatters]
keys = generic

[logger_root]
level = WARN
handlers = console
qualname =

[logger_sqlalchemy]
level = WARN
handlers =
qualname = sqlalchemy.engine

[logger_alembic]
level = INFO
handlers =
qualname = alembic

[handler_console]
class = StreamHandler
args = (sys.stderr,)
level = NOTSET
formatter = generic

[formatter_generic]
format = %(levelname)-5.5s [%(name)s] %(message)s
datefmt = %H:%M:%S
1 change: 1 addition & 0 deletions tests/alembic/alembic/README
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Generic single-database configuration.
84 changes: 84 additions & 0 deletions tests/alembic/alembic/env.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
from logging.config import fileConfig
from os import environ

from alembic import context
from sqlalchemy import engine_from_config, pool

from tests.alembic.models import BASE

# this is the Alembic Config object, which provides
# access to the values within the .ini file in use.
config = context.config
config.set_main_option(
"sqlalchemy.url",
f"postgresql://{environ.get('POSTGRES_USER')}:{environ.get('POSTGRES_PASSWORD')}"
f"@{environ.get('POSTGRESQL_HOST')}:{environ.get('POSTGRESQL_PORT')}"
f"/{environ.get('POSTGRES_DB')}",
)


# Interpret the config file for Python logging.
# This line sets up loggers basically.
if config.config_file_name is not None:
fileConfig(config.config_file_name)

# add your model's MetaData object here
# for 'autogenerate' support
# from myapp import mymodel
target_metadata = BASE.metadata
# target_metadata = None

# other values from the config, defined by the needs of env.py,
# can be acquired:
# my_important_option = config.get_main_option("my_important_option")
# ... etc.


def run_migrations_offline() -> None:
"""Run migrations in 'offline' mode.
This configures the context with just a URL
and not an Engine, though an Engine is acceptable
here as well. By skipping the Engine creation
we don't even need a DBAPI to be available.
Calls to context.execute() here emit the given string to the
script output.
"""
url = config.get_main_option("sqlalchemy.url")
context.configure(
url=url,
target_metadata=target_metadata,
literal_binds=True,
dialect_opts={"paramstyle": "named"},
)

with context.begin_transaction():
context.run_migrations()


def run_migrations_online() -> None:
"""Run migrations in 'online' mode.
In this scenario we need to create an Engine
and associate a connection with the context.
"""
connectable = engine_from_config(
config.get_section(config.config_ini_section, {}),
prefix="sqlalchemy.",
poolclass=pool.NullPool,
)

with connectable.connect() as connection:
context.configure(connection=connection, target_metadata=target_metadata)

with context.begin_transaction():
context.run_migrations()


if context.is_offline_mode():
run_migrations_offline()
else:
run_migrations_online()
26 changes: 26 additions & 0 deletions tests/alembic/alembic/script.py.mako
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
"""${message}

Revision ID: ${up_revision}
Revises: ${down_revision | comma,n}
Create Date: ${create_date}

"""
from typing import Sequence, Union

from alembic import op
import sqlalchemy as sa
${imports if imports else ""}

# revision identifiers, used by Alembic.
revision: str = ${repr(up_revision)}
down_revision: Union[str, None] = ${repr(down_revision)}
branch_labels: Union[str, Sequence[str], None] = ${repr(branch_labels)}
depends_on: Union[str, Sequence[str], None] = ${repr(depends_on)}


def upgrade() -> None:
${upgrades if upgrades else "pass"}


def downgrade() -> None:
${downgrades if downgrades else "pass"}
3 changes: 3 additions & 0 deletions tests/alembic/models.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from openeo_fastapi.client.psql.settings import BASE

metadata = BASE.metadata
Loading

0 comments on commit c7dea5c

Please sign in to comment.