#1040 SMILES/SMARTS import: Files with S-Group cause an error #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented import support for Data S-Groups. Implemented import support for all fields for Polymer S-Groups. Implemented corresponding UTs into indigo-core-unit-tests.
Implemented export support for Data S-Groups. Implemented export support for all fields for Polymer S-Groups. Implemented corresponding UTs into indigo-core-unit-tests.
Fix clang-format.
Fix clang-format.
Fix integration UTs Small fixes in smiles_loader.cpp Implemented corresponding UTs into indigo-core-unit-tests.
fix UT for issue 1200 UT.
AlexanderSavelyev
previously requested changes
Jul 27, 2023
Added constants instead of literal in smiles_loader.cpp
even1024
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented import support for Data S-Groups.
Implemented import support for all fields for Polymer S-Groups.
Implemented export support for Data S-Groups.
Implemented export support for all fields for Polymer S-Groups.
Implemented corresponding UTs into indigo-core-unit-tests.
Fix integration UTs.