Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat-e2e): implemented tests for prompt names #1823

Merged
merged 25 commits into from
Jul 29, 2024

Conversation

nartovm
Copy link
Contributor

@nartovm nartovm commented Jul 24, 2024

Description:

implemented tests for prompt names

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@nartovm
Copy link
Contributor Author

nartovm commented Jul 24, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1823.nightly-test.deltixhub.io
E2E tests status: failed

@nartovm
Copy link
Contributor Author

nartovm commented Jul 25, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1823.nightly-test.deltixhub.io
E2E tests status: success

@nartovm
Copy link
Contributor Author

nartovm commented Jul 26, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1823.nightly-test.deltixhub.io
E2E tests status: success

IlyaBondar
IlyaBondar previously approved these changes Jul 26, 2024
@nartovm
Copy link
Contributor Author

nartovm commented Jul 26, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1823.nightly-test.deltixhub.io
E2E tests status: success

@nartovm
Copy link
Contributor Author

nartovm commented Jul 26, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1823.nightly-test.deltixhub.io
E2E tests status: success

@nartovm nartovm merged commit 6ab8665 into development Jul 29, 2024
9 checks passed
@nartovm nartovm deleted the feat/special-chars-prompt-names branch July 29, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants