Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay)!: fix setting model id in overlay (Issue #2297) #2604

Open
wants to merge 22 commits into
base: development
Choose a base branch
from
Open

fix(overlay)!: fix setting model id in overlay (Issue #2297) #2604

wants to merge 22 commits into from
+167 −104

Conversation

denys-kolomiitsev
Copy link
Contributor

@denys-kolomiitsev denys-kolomiitsev commented Nov 14, 2024 •
edited
Loading

Description:

Fixed creation of the new conversation in overlay if modelId set in the overlay settings

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@denys-kolomiitsev denys-kolomiitsev self-assigned this Nov 14, 2024
@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 14, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: success

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 14, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: failed

2 similar comments
@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 14, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 15, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev denys-kolomiitsev changed the title fix: fix setting model id in overlay (Issue #2297) fix(overlay)!: fix setting model id in overlay (Issue #2297) Nov 15, 2024
@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 15, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: success

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 18, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: success

@irinakartun
Copy link
Contributor

irinakartun commented Nov 18, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: failed

@irinakartun
Copy link
Contributor

irinakartun commented Nov 18, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: failed

@irinakartun
Copy link
Contributor

irinakartun commented Nov 18, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaBondar IlyaBondar IlyaBondar left review comments

@Alexander-Kezik Alexander-Kezik Alexander-Kezik left review comments

@Gimir Gimir Awaiting requested review from Gimir Gimir is a code owner

@Derikyan Derikyan Awaiting requested review from Derikyan Derikyan is a code owner

@likeamike likeamike Awaiting requested review from likeamike likeamike is a code owner

@mikitabut mikitabut Awaiting requested review from mikitabut

@irinakartun irinakartun Awaiting requested review from irinakartun irinakartun is a code owner

@nartovm nartovm Awaiting requested review from nartovm nartovm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@denys-kolomiitsev denys-kolomiitsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denys-kolomiitsev @irinakartun @IlyaBondar @Alexander-Kezik