Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): move runtime selector to separate field (Issues #2478, #2515) #2519

Merged
merged 7 commits into from
Nov 5, 2024

Conversation

Alexander-Kezik
Copy link
Contributor

@Alexander-Kezik Alexander-Kezik commented Nov 4, 2024

Description:

move runtime selector to separate field

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Alexander-Kezik Alexander-Kezik changed the title fix(chat): move runtime selector to separate field fix(chat): move runtime selector to separate field (Issue #2478) Nov 4, 2024
@Alexander-Kezik Alexander-Kezik marked this pull request as ready for review November 4, 2024 21:35
@Alexander-Kezik
Copy link
Contributor Author

Alexander-Kezik commented Nov 4, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2519.nightly-test.deltixhub.io
E2E tests status: success

IlyaBondar
IlyaBondar previously approved these changes Nov 4, 2024
@Alexander-Kezik
Copy link
Contributor Author

Alexander-Kezik commented Nov 5, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2519.nightly-test.deltixhub.io
E2E tests status: failed

@nartovm
Copy link
Contributor

nartovm commented Nov 5, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2519.nightly-test.deltixhub.io
E2E tests status: success

@Alexander-Kezik Alexander-Kezik merged commit ee430a4 into development Nov 5, 2024
9 checks passed
@Alexander-Kezik Alexander-Kezik deleted the fix/separate-field-runtime branch November 5, 2024 11:27
@Alexander-Kezik Alexander-Kezik changed the title fix(chat): move runtime selector to separate field (Issue #2478) fix(chat): move runtime selector to separate field (Issues #2478, #2515) Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants