Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): fix app icon publishing warning message, add 'save all' option to code editor and 'save' to code editor file context menu, fix code editor empty files content (Issues #2576, #2515, #2427) #2603

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

Alexander-Kezik
Copy link
Contributor

@Alexander-Kezik Alexander-Kezik commented Nov 14, 2024

Description:

fix app icon publishing warning message
add 'save all' option to code editor and 'save' to code editor file context menu
fix code editor empty files content

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

…tion to code editor and 'save' to code editor file context menu
@Alexander-Kezik Alexander-Kezik added bug Something isn't working enhancement New feature or request labels Nov 14, 2024
@Alexander-Kezik Alexander-Kezik self-assigned this Nov 14, 2024
@Alexander-Kezik Alexander-Kezik changed the title fix(chat): fix app icon publishing warning message, add 'save all' option to code editor and 'save' to code editor file context menu, fix code editor empty files content (Issues #2576, #2515, #2427) feat(chat): fix app icon publishing warning message, add 'save all' option to code editor and 'save' to code editor file context menu, fix code editor empty files content (Issues #2576, #2515, #2427) Nov 14, 2024
@Alexander-Kezik
Copy link
Contributor Author

Alexander-Kezik commented Nov 14, 2024

/deploy-review

@Alexander-Kezik
Copy link
Contributor Author

Alexander-Kezik commented Nov 14, 2024

/deploy-review

@Alexander-Kezik
Copy link
Contributor Author

Alexander-Kezik commented Nov 14, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2603.nightly-test.deltixhub.io
E2E tests status: success

IlyaBondar
IlyaBondar previously approved these changes Nov 14, 2024
@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Nov 15, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2603.nightly-test.deltixhub.io
E2E tests status: success

@Alexander-Kezik Alexander-Kezik merged commit e2b2d89 into development Nov 15, 2024
9 checks passed
@Alexander-Kezik Alexander-Kezik deleted the fix/files-creation branch November 15, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request _priority_2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants