-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chat): fix app icon publishing warning message, add 'save all' option to code editor and 'save' to code editor file context menu, fix code editor empty files content (Issues #2576, #2515, #2427) #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to code editor and 'save' to code editor file context menu
Alexander-Kezik
added
bug
Something isn't working
enhancement
New feature or request
labels
Nov 14, 2024
Alexander-Kezik
requested review from
Gimir,
denys-kolomiitsev,
IlyaBondar,
Derikyan and
likeamike
as code owners
November 14, 2024 10:46
Alexander-Kezik
changed the title
fix(chat): fix app icon publishing warning message, add 'save all' option to code editor and 'save' to code editor file context menu, fix code editor empty files content (Issues #2576, #2515, #2427)
feat(chat): fix app icon publishing warning message, add 'save all' option to code editor and 'save' to code editor file context menu, fix code editor empty files content (Issues #2576, #2515, #2427)
Nov 14, 2024
Contributor
Author
/deploy-review
|
Contributor
Author
/deploy-review
|
IlyaBondar
reviewed
Nov 14, 2024
apps/chat/src/utils/app/data/storages/api/conversation-api-storage.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
/deploy-review
|
IlyaBondar
previously approved these changes
Nov 14, 2024
/deploy-review
|
IlyaBondar
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fix app icon publishing warning message
add 'save all' option to code editor and 'save' to code editor file context menu
fix code editor empty files content
Issues:
Checklist:
fix(<scope>):
,feat(<scope>):
,feature(<scope>):
,chore(<scope>):
,hotfix(<scope>):
ore2e(<scope>):
. If contains breaking changes then the pull request name must start withfix(<scope>)!:
,feat(<scope>)!:
,feature(<scope>)!:
,chore(<scope>)!:
,hotfix(<scope>)!:
ore2e(<scope>)!:
where<scope>
is name of affected project:chat
,chat-e2e
,overlay
,shared
,sandbox-overlay
, etc.(Issue #<TICKET_ID>)
(comma-separated list of issues)