Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight atoms and bonds #4984

Closed
AlekseiKhariukov opened this issue Jul 3, 2024 · 1 comment · Fixed by #5594
Closed

Highlight atoms and bonds #4984

AlekseiKhariukov opened this issue Jul 3, 2024 · 1 comment · Fixed by #5594

Comments

@AlekseiKhariukov
Copy link
Collaborator

AlekseiKhariukov commented Jul 3, 2024

Ketcher API includes functions that allow highlighting atoms and bonds of the drawing with a colored background. This feature is not available from within Ketcher UI, so regular users cannot do the highlighting.

Introduce new 'Highlight' item in the atom/bond context menu that would allow user to highlight selected atoms and bonds. User should be able to select one of eight predefined highlight colors or clear the highlighting.

The new menu item should be added to the following menu positions:

  • In the atom context menu -- below 'Add attachment point';
  • In the bond context menu -- below 'Attach S-Group...';
  • In the context menu for a selection of atoms and bonds -- below 'Enhanced stereochemistry...', separated by a horizontal delimiter line.

Specific colors are highlighted in the mockup below. Please note that the new menu item is drawn on a wrong position.

Screenshot 2024-10-02 at 11 36 25 Screenshot 2024-10-02 at 11 40 09 Screenshot 2024-10-02 at 11 41 37
@KristinaKasyanovskaya KristinaKasyanovskaya linked a pull request Sep 26, 2024 that will close this issue
10 tasks
NataliaLoginova pushed a commit that referenced this issue Oct 1, 2024
* feat: add new context-menu part

* test: update test

* fix:fix changes according to comments in PR

* test: update test

* test:update test

* feat: improve menu according to the new design

* fix:#5598 double bond is colored

* Revert "fix:#5598 double bond is colored"

This reverts commit 0eac85c.
@AnnaKosol
Copy link
Collaborator

Screenshot 2024-10-08 at 12 38 06

Verified

Environment
https://rc.test.lifescience.opensource.epam.com/KetcherDemoSA/index.html
Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
Indigo Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
MacOs
Chrome 129.0.6668.71 (Official Build) (arm64)

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
* feat: add new context-menu part

* test: update test

* fix:fix changes according to comments in PR

* test: update test

* test:update test

* feat: improve menu according to the new design

* fix:#5598 double bond is colored

* Revert "fix:#5598 double bond is colored"

This reverts commit 0eac85c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants