Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only bonds is highlighted when the whole molecule with atoms is choosen #5668

Closed
AnnaKosol opened this issue Oct 7, 2024 · 2 comments · Fixed by #5758 or #5772
Closed

Only bonds is highlighted when the whole molecule with atoms is choosen #5668

AnnaKosol opened this issue Oct 7, 2024 · 2 comments · Fixed by #5758 or #5772
Assignees
@aproskurnov
Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium Team G
Milestone
Ketcher 2.26.0-rc.5

Comments

@AnnaKosol
Copy link
Collaborator

Steps to Reproduce

  1. add the molecule to the Canvas
Screenshot 2024-10-07 at 15 34 21
  1. choose the whole molecule
Screenshot 2024-10-07 at 15 41 21
  1. open highlight menu and choose color
Screenshot 2024-10-07 at 15 42 26

Actual behavior
only bonds are highlighted
Screenshot 2024-10-07 at 15 43 13

Expected behavior
the whole molecule is highlighted

Environment

  • Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
  • Indigo Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • MacOs
  • Chrome 129.0.6668.71 (Official Build) (arm64)

Issue found while testing #4984
@AnnaKosol AnnaKosol added this to the Ketcher 2.26.0-rc.2 milestone Oct 7, 2024
@AlexeyGirin AlexeyGirin added Team G Micromolecules canvas Bucket: Micromolecules canvas related issues labels Oct 8, 2024
@aproskurnov aproskurnov linked a pull request Oct 14, 2024 that will close this issue
Backmerge: Only bonds highlighting created when select bonds + atoms together #5758
Merged
9 tasks
@aproskurnov aproskurnov linked a pull request Oct 16, 2024 that will close this issue
#5758 Highlight only bonds when selected bonds + atoms #5772
Merged
9 tasks
@rrodionov91 rrodionov91 reopened this Oct 18, 2024
@rrodionov91
Copy link
Collaborator

Need merge into 2.26

@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.

2024-10-21_19h11_05
2024-10-21_19h11_25
2024-10-21_19h11_57
2024-10-21_19h12_11
2024-10-21_19h12_36
2024-10-21_19h13_02

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.5]
Indigo version
[Version 1.25.0-rc.3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aproskurnov aproskurnov

Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium Team G
Projects
None yet
Milestone
Ketcher 2.26.0-rc.5
8 participants
@aproskurnov @svvald @NataliaLoginova @rrodionov91 @AlexeyGirin @Zhirnoff @Guch1g0v @AnnaKosol