Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autotests: Replace Copy/Cut/Paste keyboard operations with valid helper functions #5903

Closed
AlexeyGirin opened this issue Nov 4, 2024 · 1 comment · Fixed by #5959
Closed

Autotests: Replace Copy/Cut/Paste keyboard operations with valid helper functions #5903

AlexeyGirin opened this issue Nov 4, 2024 · 1 comment · Fixed by #5959
Assignees
@knadonenko
Labels
Autotests
Milestone
Autotests

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Nov 4, 2024 •
edited
Loading

Identify all Control+A, Control+X, Control+C, Control+V operations made by keyboard and replace them with
Control+C ==> copyToClipboardByKeyboard(page)
Control+X ==> cutToClipboardByKeyboard(page)
Control+V ==> pasteFromClipboardByKeyboard(page)
Control+A ==> selectAllStructuresOnCanvas(page)
methods

Recommendation: Try to search "page.keyboard.press(" in code
That could be page.keyboard.press('Control+v');
or page.keyboard.press('${modifier}+KeyC'); or similar
@AlexeyGirin AlexeyGirin added this to the Autotests milestone Nov 4, 2024
@knadonenko
Copy link
Collaborator

In progress

@AlexeyGirin AlexeyGirin changed the title Autotests: Replace Copy/Cut/Paste keyboard operations with valid hepler fuctions Autotests: Replace Copy/Cut/Paste keyboard operations with valid helper functions Nov 4, 2024
@knadonenko knadonenko self-assigned this Nov 4, 2024
knadonenko pushed a commit that referenced this issue Nov 12, 2024
@knadonenkoepam
Merge branch 'master' into #5903---Replace-Copy/Cut/Paste-keyboard-op…
87620dc 
…erations

# Conflicts:
#	ketcher-autotests/tests/Macromolecule-editor/Macro-Micro-Switcher/macro-micro-switcher.spec.ts
knadonenko pushed a commit that referenced this issue Nov 14, 2024
@knadonenkoepam
Merge branch 'master' of https://github.com/epam/ketcher into #5903--…
79b80fd 
…-Replace-Copy/Cut/Paste-keyboard-operations
AlexeyGirin pushed a commit that referenced this issue Nov 14, 2024
@knadonenko @knadonenkoepam
#5903 replace copy/cut/paste keyboard operations (#5959)
9feee7c 
* Changed ctrl+c to copyToClipBoardByKeyboard

* removed unused

* Control + V changed to pasteFromClipboardByKeyboard

* Control+X replaced by cutToClipboardByKeyboard

* Fix

* cut and paste with modifier changed

* changing steps with modifier

* fixed warnings

* fix

* test fixes, screenshots changed

* update screenshots

---------

Co-authored-by: Konstantin_Nadonenko <konstantin_nadonenko@epam.com>
@AlexeyGirin AlexeyGirin linked a pull request Nov 14, 2024 that will close this issue
#5903 replace copy/cut/paste keyboard operations #5959
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knadonenko knadonenko

Labels
Autotests
Projects
None yet
Milestone
Autotests
Development

Successfully merging a pull request may close this issue.

#5903 replace copy/cut/paste keyboard operations epam/ketcher
2 participants
@knadonenko @AlexeyGirin