Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4984-Highlight atoms and bonds #5594

Merged
merged 10 commits into from
Oct 1, 2024
Merged

#4984-Highlight atoms and bonds #5594

merged 10 commits into from
Oct 1, 2024

Conversation

KristinaKasyanovskaya
Copy link
Collaborator

@KristinaKasyanovskaya KristinaKasyanovskaya commented Sep 26, 2024 •
edited
Loading

Issue => #4984

  • The new menu item added
Снимок экрана 2024-09-29 в 23 32 33

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@KristinaKasyanovskaya KristinaKasyanovskaya linked an issue Sep 26, 2024 that may be closed by this pull request
Highlight atoms and bonds #4984
Closed
@rrodionov91 rrodionov91 self-requested a review October 1, 2024 11:06
@rrodionov91 rrodionov91 dismissed their stale review October 1, 2024 11:06

Another reviewer assigned

@NataliaLoginova NataliaLoginova merged commit 93e32ab into master Oct 1, 2024
5 checks passed
@NataliaLoginova NataliaLoginova deleted the 4984-highlight-atoms-and-bonds branch October 1, 2024 11:07
Guch1g0v pushed a commit that referenced this pull request Oct 17, 2024
@KristinaKasyanovskaya @Guch1g0v
#4984-Highlight atoms and bonds (#5594)
afddd29 
* feat: add new context-menu part

* test: update test

* fix:fix changes according to comments in PR

* test: update test

* test:update test

* feat: improve menu according to the new design

* fix:#5598 double bond is colored

* Revert "fix:#5598 double bond is colored"

This reverts commit 0eac85c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaLoginova NataliaLoginova NataliaLoginova approved these changes

@svvald svvald Awaiting requested review from svvald

@Zhirnoff Zhirnoff Awaiting requested review from Zhirnoff

@rrodionov91 rrodionov91 Awaiting requested review from rrodionov91

Assignees

@KristinaKasyanovskaya KristinaKasyanovskaya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight atoms and bonds
3 participants
@KristinaKasyanovskaya @NataliaLoginova @rrodionov91