refactor: check if attr is valid on boot

epessine · Jun 1, 2024 · 4331675 · 4331675
1 parent 4e27cee
commit 4331675
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/src/Attributes/Vessel.php b/src/Attributes/Vessel.php
@@ -26,6 +26,15 @@ public function __construct()
 
     public function boot(): void
     {
+        $class = $this->getVesselClass();
+
+        if (! is_a($class, BaseVessel::class, true)) {
+            throw new BadVesselMethodException(
+                $this->component->getName(),
+                $this->getName(),
+            );
+        }
+
         off('__get', $this->handleMagicGet(...));
         on('__get', $this->handleMagicGet(...));
 
@@ -50,7 +59,7 @@ public function boot(): void
                     });
                 });
             </script>
-        HTML, $this->getVesselClass().'-'.$contextId);
+        HTML, $class.'-'.$contextId);
     }
 
     /**
@@ -114,16 +123,7 @@ protected function getVesselClass(): string
 
     protected function getVessel(): object
     {
-        $class = $this->getVesselClass();
-
-        if (! is_a($class, BaseVessel::class, true)) {
-            throw new BadVesselMethodException(
-                $this->component->getName(),
-                $this->getName(),
-            );
-        }
-
-        return new $class($this->component);
+        return new ($this->getVesselClass())($this->component);
     }
 
     public function getName(): string