fix(menus): isStart function not called on classed based menus

ephrimlawrence · Mar 19, 2024 · 2cc1321 · 2cc1321
1 parent 74d53e4
commit 2cc1321
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/menus/base.menu.ts b/src/menus/base.menu.ts
@@ -13,19 +13,19 @@ export abstract class BaseMenu {
     return true;
   }
 
-  async paginate(): Promise<boolean> {
+  paginate(): Promise<boolean> | boolean {
     return false;
   }
 
-  abstract message(): Promise<string>;
+  abstract message(): Promise<string> | string;
 
-  abstract nextMenu(): Promise<string | undefined>;
+  abstract nextMenu(): Promise<string | undefined> | string | undefined;
 
   /**
    * Terminate the current session
    *
    */
-  async end(): Promise<boolean> {
+  end(): Promise<boolean> | boolean {
     return false;
   }
 
@@ -34,8 +34,8 @@ export abstract class BaseMenu {
     return this.request.query?.sessionid!;
   }
 
-  async isStart(): Promise<boolean> {
-    return Promise.resolve(false);
+  isStart(): Promise<boolean> | boolean {
+    return false
   }
 
   get session(): Session {

diff --git a/src/menus/index.ts b/src/menus/index.ts
@@ -55,7 +55,7 @@ export class Menus {
           isStart = await menu.isStart()
         } else {
           // @ts-ignore
-          isStart = (await new menu(req, res).isStart)
+          isStart = (await new menu(req, res).isStart())
         }
       } else {