Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the 3rd option of sequencer source, install the template #194

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

hongran
Copy link
Contributor

@hongran hongran commented Nov 5, 2024

I added the Front2 and all Rear ports to the source of sequencer.
I also changed the Makefile to install the template file.

Comment on lines 66 to 67
field(FTST, "Rear1")
field(FFST, "Rear2")
Copy link
Contributor

@jerzyjamroz jerzyjamroz Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move it to a separate mbbo so it does not split Rear0..15.

Copy link
Contributor

@jerzyjamroz jerzyjamroz Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the same so Univ0..15 into one mbbo - this is affected.
field(TTST, "Univ0")
field(FTST, "Univ1")
field(FFST, "Univ2")

@@ -62,6 +62,9 @@ record(mbbo, "$(P)TrigSrc$(s=:)1-Sel") {
field(TEST, "Univ13")
field(ELST, "Univ14")
field(TVST, "Univ15")
field(TTST, "Front2")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move it to: $(P)TrigSrc-Sel after Front1.

@jerzyjamroz jerzyjamroz self-assigned this Nov 6, 2024
@@ -25,7 +25,7 @@ DB += evgDbus.db
DB += evgAcTrig.db
DB += evgInput.db
DB += evgOutput.db
DB += evgSoftSeq.db
DB += evgSoftSeq.template
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use evgSoftSeq.db in the installation. For what do you need that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evgSoftSeq.db has implemented the default substitutions. When I am trying to build the database for our APS application, I found that I did need the PP macro.

@hongran
Copy link
Contributor Author

hongran commented Nov 6, 2024

I will rearrange the entries of the mbbo records. I kept the existing form so that it won't break existing system's auto-restore.

@hongran
Copy link
Contributor Author

hongran commented Nov 8, 2024

I just updated the mbbo records.

@jerzyjamroz jerzyjamroz merged commit 521148f into epics-modules:master Nov 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants