Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import s3gw fixes for E, and s3gw version bump #2494

Closed
wants to merge 1 commit into from

Conversation

andreas-kupries
Copy link
Contributor

Ref epinio/helm-charts#466

Imports bump to s3gw 0.18, and the fixes needed for E to handle it.

@andreas-kupries andreas-kupries added kind/bug Something isn't working kind/dependencies labels Aug 1, 2023
@andreas-kupries andreas-kupries added this to the v1.10.0 milestone Aug 1, 2023
@andreas-kupries andreas-kupries self-assigned this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.13% ⚠️

Comparison is base (7984eb5) 67.63% compared to head (a136235) 67.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2494      +/-   ##
==========================================
- Coverage   67.63%   67.51%   -0.13%     
==========================================
  Files         184      184              
  Lines       15394    15394              
==========================================
- Hits        10412    10393      -19     
- Misses       3947     3962      +15     
- Partials     1035     1039       +4     
Flag Coverage Δ
acceptance-api 49.26% <ø> (-0.12%) ⬇️
acceptance-apps 38.24% <ø> (ø)
acceptance-cli 63.81% <ø> (-0.09%) ⬇️
unittests 13.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreas-kupries
Copy link
Contributor Author

Ok. CI ✔️ , the changes are ok for the standard setup. s3gw setup to be done manually.

@andreas-kupries
Copy link
Contributor Author

Manual run with 2 failures which do not look related.
Rerun focused on the two failed tests one is ok, and the re-pushing a fix does not seem to get better.
Left with a single failure. Timeout while waiting for the previous staging job to complete.

@andreas-kupries andreas-kupries marked this pull request as ready for review August 1, 2023 12:13
@andreas-kupries andreas-kupries requested a review from a team as a code owner August 1, 2023 12:13
@enrichman enrichman closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/dependencies
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants