fix S3_CERTIFICATE_SECRET env var value when using s3gw #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
The app deployment when using s3gw 0.18.0 works ok with this fix. Anyway we downgraded to s3gw 0.14.0 where this fix is not needed (and has correct resource names) so this might be relevant for later E releases with bumped s3gw. |
andreas-kupries
previously approved these changes
Jul 31, 2023
Fixes: epinio/epinio#2466 Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
andreas-kupries
force-pushed
the
fix-s3gw-S3_CERTIFICATE_SECRET-envvar
branch
from
35ed427
to
3af145b
Compare
|
this PR must be patched using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix epinio/epinio#2466
Fix #470 - Added
(andreas-kupries) My plan is to have fix and bump (back to 0.18) in a single PR, this here.