This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Copy response headers through proxied requests #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torchiaf
changed the title
richard-cox
suggested changes
Jul 25, 2023
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
richard-cox
suggested changes
Aug 3, 2023
| @@ -593,6 +594,10 @@ func (p *portalProxy) ProxySingleRequest(c echo.Context) error { | |||
| go p.doRequest(&cnsiRequest, done) | |||
| res := <-done | |||
|
|
|||
| // Copy custom content-length header from original response header | |||
| contentLength := "x-content-length" | |||
| c.Response().Header().Set(contentLength, res.ResponseHeader.Get(contentLength)) | |||
There was a problem hiding this comment.
i still couldn't get this to work, the status bar does not change until the download has finished.
realised why though, we need to pipe updates from the proxied request (ui backend --> epinio) to the client request (client --> ui backend)
|
I've just merged epinio/ui#286, so these changes need porting to the new location |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The response headers are truncate for proxied https requests to Epinio server.
Motivation and Context
One of the missing response headers is
X-Content_Length, which should be used to calculate download progress on the UI.Related issue: epinio/ui#223