[ui] Replace single redeploy request with update + deploy requests

[richard-cox]

• Blocked on Cannot update source from a failed app epinio#2363
• The redeploy api request will be removed
• We need to replace this with two requests now. update and deploy
• Affects two places (need to check for other places)
  • adding / removing instances using the + / - buttons
    • any requests here should be debounced such that if the user clicks multiple times we only deploy once they have stopped. Split out to Scale instances without waiting #287
  • editing application source
• before starting we should discuss offering the user the choice on whether they want to deploy the app following the changes.
  • this could be a checkbox in the edit app source flow somewhere

[enrichman]

We don't need the two API calls because in the end I've kept the original behavior adding a flag to skip the restart, so we just need to provide this flag during the push.

See: epinio/epinio#2363 (comment)

[richard-cox]

@torchiaf unfortunately we don't have the same bot from dashboard running here, so we need to make sure issues that are automatically closed by PRs are reopened and moved to test

[mmartin24]

@richard-cox could you please give some hints on how to test this?
thanks

[torchiaf]

@mmartin24 This will fix this issue.

Area that should be covered by tested:

• Edit a faulty app .
• Scale applications (regressions check).

The last point in the description is actually not covered, possibly we may want to address it in a new issue.

[mmartin24]

Checked in Epinio Server Version: v1.9.0-26-g21ef05bd with latest Epinio UI.

• Checked faulty up can be sourced to a working one.
• Checked once sourced to a valid one, it can scaled up and down 3 instances

Screencast.from.01-09-23.11.55.31.mov

(Testing note: use make appchart when deploying testing cluster if local)

[mmartin24]

@mmartin24 This will fix this issue.

Area that should be covered by tested:

• Edit a faulty app .
• Scale applications (regressions check).

The last point in the description is actually not covered, possibly we may want to address it in a new issue.

Thanks @torchiaf .
Tested accordingly and working.
I think the last point you mentioned regarding application scaling is covered here: #287

Closing issue

[mmartin24]

Rechecked in v1.10.0-rc1 and working:

• Checked redeploying app from faulty one
• Checked up and downscale of apps to 3 instances