[ui] Custom Variables are not validated in Application edit mode

[torchiaf]

Setup

• Epinio UI version: 1.9.0

To Reproduce

1- Edit an application having at least a custom variable with constraints (i.e. numeric variable with min value)
2- Set an invalid value. (i.e. min=5 value= 2)

Result
The Save button is enabled

Expected Result

Save button should be disabled.

Screenshots

[thehejik]

EDIT: 09/23 the comment is unrelated, this issue is about Edit Config on Application (not Service)

Edit mode still not working, everything inactive so can't say if the values are validated but I can still press Save even if the form is inactive (the valid values entered when creating the service).

I guess some piece is still missing for the service Edit Mode enablement.

[thehejik]

Moving to In Progress until #252 is in.

[richard-cox]

@thehejik This issue is about application chart values, rather than service chart values. Would it be ok to create a validation issue for 1.11 for service chart values?

[richard-cox]

I've added a note to the edit service values issue to ensure values are validated #252 (comment).

[thehejik]

The validation works absolutely ok in chromium/vivaldi.

But doesn't work at all in Firefox, note the appListeningPort is integer with min: 0

[thehejik]

This is from chromium/vivaldi, all the fields are validated and Save button is Inactive when even one value is out of range, also I was unable to write any letters into integer/number fields.

[thehejik]

Given the PR is merged and firefox issue opened I'm closing this one.

[mmartin24]

Verified in v1.10.0-rc2 using Brave browser

• Negative values not allowed in appListeningPort
• Letters or special chars cannot be printed in screen in Chromium browsers. However this is possible in Firefox ones as mentioned in [ui] Fields are not validated in Edit Config->Details for Applications under Firefox #348