Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Applications modal, enhancements #301

Closed
torchiaf opened this issue Aug 9, 2023 · 2 comments · Fixed by #306
Closed

Export Applications modal, enhancements #301

torchiaf opened this issue Aug 9, 2023 · 2 comments · Fixed by #306
Assignees
@torchiaf
Labels
blocked-dashboard kind/enhancement New feature or request
Milestone
v1.10.0

Comments

@torchiaf
Copy link
Contributor

torchiaf commented Aug 9, 2023 •
edited
Loading

Related issues: #261

Export applications modal should be block, so if the user accidentally clicks outside of modal they don't lose the last x minutes of progress.

Nice-to-have features

Clicking cancel button / pressing Esc should cancel download.
@torchiaf torchiaf added the kind/enhancement New feature or request label Aug 9, 2023
@torchiaf torchiaf added this to the v1.10.0 milestone Aug 9, 2023
@torchiaf torchiaf self-assigned this Aug 9, 2023
This was referenced Aug 11, 2023
Merged
Merged
@torchiaf torchiaf changed the title [ui] Block export dialog to avoid closing when user clicks outside Export Applications modal, enhancements Aug 11, 2023
@richard-cox richard-cox modified the milestones: v1.10.0, v1.11.0 Aug 14, 2023
@torchiaf torchiaf reopened this Aug 21, 2023
@mmartin24
Copy link
Contributor

Tested in Epinio Server Version: v1.9.0-23-g58d35b2e with latest ui image ghcr.io/epinio/epinio-ui:latest-next

  • Checked pressing Esc / Cancel actually stops the export of images and charts
  • Checked pressing outside the export window does not close the window and the download continues

The only thing to mention is that if Esc / Cancel is pressed when is compressing the files will not be stopped. Given that the compression will be part of the download on another ticket, I assume this as normal.

image

@mmartin24
Copy link
Contributor

Restested in Epinio v1.10.0-rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torchiaf torchiaf

Labels
blocked-dashboard kind/enhancement New feature or request
Projects
Epinio planning
Archived in project
UI
Status: Done
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

Improve Export Applications modal
3 participants
@richard-cox @torchiaf @mmartin24