Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Service/Application charts values, add support for complex types #302

Open
Tracked by #252
torchiaf opened this issue Aug 10, 2023 · 2 comments
Open
Tracked by #252
Assignees
Labels
Milestone

Comments

@torchiaf
Copy link
Contributor

torchiaf commented Aug 10, 2023

Needs to support Chart values - complex types.

References:

@torchiaf torchiaf added the kind/enhancement New feature or request label Aug 10, 2023
@torchiaf torchiaf added this to the v1.10.0 milestone Aug 10, 2023
@torchiaf torchiaf self-assigned this Aug 10, 2023
@torchiaf torchiaf changed the title [ui] Service/Application charts values, support array tipes [ui] Service/Application charts values, add support for array types Aug 10, 2023
@richard-cox richard-cox moved this to Icebox in Epinio planning Aug 14, 2023
@richard-cox richard-cox moved this to Backlog in UI Aug 14, 2023
@richard-cox
Copy link
Member

richard-cox commented Aug 14, 2023

Had a look at the docs, they support maps and also mixtures of arrays and maps.

We should be able to handle maps (something like keyvalue with uneditable keys). For anything else we may need to show a json editor and validate context locally?

  • map with simple values
  • array with simple values
    • there doesn't seem to be an indication in the service spec if something should be an array or not
  • array with maps
  • map as value
    • this will be challenging to include in a fixed form. we would need to be able to determine from spec if the type is a map... and probably just show free text

There seems to be a lot going on here that isn't supported in app values (which are just simple values - https://deploy-preview-265--epinio-docs-staging.netlify.app/next/howtos/create_custom_appcharts).

@thehejik
Copy link
Contributor

see another ref. epinio/epinio#2485

@andreas-kupries andreas-kupries moved this from Icebox to Scheduled in Epinio planning Aug 30, 2023
@torchiaf torchiaf moved this from Backlog to In progress in UI Sep 4, 2023
@richard-cox richard-cox modified the milestones: v1.10.0, v1.11.0 Sep 4, 2023
@richard-cox richard-cox modified the milestones: v1.11.0, v1.12.0 Nov 20, 2023
@torchiaf torchiaf changed the title [ui] Service/Application charts values, add support for array types [ui] Service/Application charts values, add support for complex types Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Scheduled
Status: In progress
Development

No branches or pull requests

3 participants