Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] 'Epinio' text is replaced by 'Rancher' after refreshing in 'About' page #315

Closed
mmartin24 opened this issue Aug 22, 2023 · 3 comments · Fixed by #318
Closed

[UI] 'Epinio' text is replaced by 'Rancher' after refreshing in 'About' page #315

mmartin24 opened this issue Aug 22, 2023 · 3 comments · Fixed by #318
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@mmartin24
Copy link
Contributor

Setup

  • Epinio version: v1.9.0-21-g4b1a314b
  • Epinio UI version:
│     Image:          ghcr.io/epinio/epinio-ui:latest-next                                                                                                                                       
│     Image ID:       ghcr.io/epinio/epinio-ui@sha256:c9c9c1e94d5d7b5f59a58eabbca09ac4c302588de6e602699155d791ccdd9755     
  • Browser type & version: Brave Version 1.57.47 Chromium: 116.0.5845.96 (Official Build) (64-bit)

Describe the bug
In about page links that contain the word 'Epinio' such as the binaries download links and links to Epinio repo are substituted by the text Rancher right after refreshing.

To Reproduce

  • Deploy latest Epinio BE
  • Deploy latest UI using kubectl set image -n epinio deployment/epinio-ui epinio-ui=ghcr.io/epinio/epinio-ui:latest-next
  • Go to About page
  • Observe text 'Epinio' on links to repo and binary downloads
  • Refresh page

Result
Epinio text is substituted by Rancher one.

Expected Result
Epinio text is should remain

Screenshots

Before refresh:
image

After refresh:
image

Video:

Screencast.from.21-08-23.18.23.12.mov

Additional context

@mmartin24 mmartin24 added the kind/bug Something isn't working label Aug 22, 2023
@mmartin24 mmartin24 added this to UI Aug 22, 2023
@mmartin24 mmartin24 changed the title 'Epinio' text is replaced by 'Rancher' after refreshing in 'About' page [UI] 'Epinio' text is replaced by 'Rancher' after refreshing in 'About' page Aug 22, 2023
@andreas-kupries andreas-kupries moved this to Icebox in Epinio planning Aug 22, 2023
@richard-cox
Copy link
Member

this will be a routing issue, and should be addressed the same time as #309

@richard-cox
Copy link
Member

richard-cox commented Aug 29, 2023

This should be resolved as part of changes made in #318. The fetch to get product name fails due to changes upstream with urls (adding query params)

image

@richard-cox richard-cox self-assigned this Aug 29, 2023
@richard-cox richard-cox moved this from Next Up to Review in UI Aug 29, 2023
@torchiaf torchiaf moved this from Review to To Test in UI Aug 30, 2023
@enrichman enrichman moved this from Icebox to Scheduled in Epinio planning Aug 30, 2023
@mmartin24
Copy link
Contributor Author

Regression UI test 'Check "About" page and main links' passed after fix.
Manually checked as well on Epinio Server Version: v1.9.0-24-g3863a0d5 and latest UI image image: ghcr.io/epinio/epinio-ui:latest-next after refreshing UI and working:

image

@github-project-automation github-project-automation bot moved this from Scheduled to Done in Epinio planning Aug 31, 2023
@github-project-automation github-project-automation bot moved this from To Test to Done in UI Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants