Add link buttons from dashboard deployment to epinio app #276
Conversation
dashboard/pkg/epinio/index.ts
Outdated
| * | ||
| * Backend should provide a reliable list of epinio annotations | ||
| */ | ||
| return !!Object.keys(ctx.metadata.annotations).find((k) => k.startsWith('epinio.io')); |
There was a problem hiding this comment.
epinio.io/app-container
epinio.io/created-by
|
@andreas-kupries @mmartin24 This PR will add links from Rancher Manager dashboard to Epinio applications, filtering those pods/jobs created by Epinio. |
dashboard/pkg/epinio/index.ts
Outdated
| }, | ||
| invoke(_: ActionOpts, values: any[]) { | ||
| const obj = values[0]; | ||
| const component = this as any; |
There was a problem hiding this comment.
I think we need to rework this
- We shouldn't take the user to the standalone epinio UI but to the embedded epinio page. We're trying to add value for the embedded use case, which is avoided if we don't use it
- At this point we can go on the assumption that the current cluster is an epinio cluster and avoid checking if the ingress exists
So given above we don't need to assume the this context is a component, and avoid using the $store.
There was a problem hiding this comment.
You are right, I was pointing to the standalone instance. Fixed
dashboard/pkg/epinio/index.ts
Outdated
|
|
||
| const url = `${ baseUrl }/epinio/c/default/applications/${ epinioNamespace }/${ epinioAppName }`; | ||
|
|
||
| window.open(url, '_blank'); |
There was a problem hiding this comment.
Given above this can now take the user to the embedded pages via $route
| { | ||
| resource: [ | ||
| // put other epinio application's objects | ||
| 'apps.deployment', |
There was a problem hiding this comment.
we can only link from a deployment, pod, or a workload if it is a deployment or pod.
we might be able to do service as well, which goes to a service instance
There was a problem hiding this comment.
I will disable services for the moment, even if we could put the link from a service bounded to an application to the application view on Epinio.
There was a problem hiding this comment.
'batch.job' can be removed as well
…to Epinio dashboard Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
There was a problem hiding this comment.
- i created Navigating from an app detail page a cluster in cluster explorer throws white page error #307 to cover the bug from app details to cluster explorer cluster. i don't think it's related to this PR
dashboard/pkg/epinio/l10n/en-us.yaml
Outdated
| @@ -284,6 +284,8 @@ epinio: | |||
| label: Download Manifest | |||
| editFromCommit: | |||
| label: Redeploy | |||
| goToEpinio: | |||
| label: App Details | |||
There was a problem hiding this comment.
Didn't spot this before. This should be labelled Epinio App, possibly Epinio Details? Either way, think it should be clearer where the user ends up
There was a problem hiding this comment.
I'm in favor of Epinio App. Epinio Details i think is too long.
| { | ||
| resource: [ | ||
| // put other epinio application's objects | ||
| 'apps.deployment', |
There was a problem hiding this comment.
'batch.job' can be removed as well
…able apps Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Summary
Fixes #271
List of annotations for Epinio pods:
Known issues
rancher/dashboard#9330fixed in theshellpkg.