Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move epinio/ui-backend into epinio/ui #286

Merged
merged 10 commits into from
Aug 3, 2023
Merged

Move epinio/ui-backend into epinio/ui #286

merged 10 commits into from
Aug 3, 2023

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Jul 25, 2023 •
edited
Loading

Summary

Fixes #269

Occurred changes and/or fixed issues

  • Moved content from epinio/ui-backend to epinio/ui backend
  • Moved things from root of backend out to where they should be
    • updated root .gitignore
    • moved .github/workflows
  • Updated lots of paths given change of location (scripts) and repo (go deps)

There's two gh workflows that build releases. One nightly, one on tag. We should be able to get the release one pretty solid by fixing the nightly. I've tested what i can, but we'll probably need to iterate

Areas or cases that should be tested

  • Run backend .. and run dashboard... test together
    • All docs in PR should be updated with the new instructions. It's basically though run the ui backend from epinio/ui backend rather than epinio/ui-backend

@richard-cox
Change set one
c5da5d3 
- move most files over
- fix some directory paths
- still in progress - go releaser & build scripts
@richard-cox
Update go dep paths
54d2d7a
@richard-cox
First pass at release process
fef1641
@richard-cox richard-cox self-assigned this Jul 25, 2023
@richard-cox richard-cox marked this pull request as draft July 25, 2023 16:19
@richard-cox richard-cox added this to the v1.10.0 milestone Jul 25, 2023
@richard-cox richard-cox marked this pull request as ready for review July 26, 2023 14:29
@enrichman
Copy link
Member

There is too much to check, it's probably easier to merge and iterate/check.
We have just released so we have time to do that.

We should also probably disable the old scheduled releases in the old repo to avoid conflicts.

@enrichman
Copy link
Member

I've seen also the release drafter action/config, so this will probably fix #281 as well.

torchiaf
torchiaf approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI & backend works if running together locally. LGTM

@richard-cox richard-cox merged commit 0aed8ce into main Aug 3, 2023
4 checks passed
@richard-cox richard-cox deleted the migrate-bk branch August 3, 2023 13:10
@richard-cox richard-cox mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torchiaf torchiaf torchiaf approved these changes

@enrichman enrichman enrichman approved these changes

Assignees

@richard-cox richard-cox

Labels
None yet
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

[ui] Move epinio/ui-backend code to epinio/ui
3 participants
@richard-cox @enrichman @torchiaf