-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Export Applications modal #306
Conversation
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some strangeness after Cancel
ing the modal and trying again
- The cancel side looks like it works fine
- Trying to download the image again though results in a failure and a bad error message in a banner
- The correct error should be presented to the user
- There should be a BE ticket to ensure that
the job creating the exported image is cancelled if the http request is cancelledexport of app image requests can be concurrent
With those two things addressed we're good to merge this
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
I just created a new issue to take note of the export error: epinio/epinio#2516 and pushed a change to handle the error messages on the UI. |
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Summary
Fixes #301
Technical Notes