Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Export Applications modal #306

Merged
merged 7 commits into from
Aug 21, 2023
Merged

Improve Export Applications modal #306

merged 7 commits into from
Aug 21, 2023

Conversation

torchiaf
Copy link
Contributor

@torchiaf torchiaf commented Aug 11, 2023

Summary

Fixes #301

Technical Notes

  • Avoid close Export Applications modal when clicking outside
  • Cancel download request on click close button

@torchiaf torchiaf self-assigned this Aug 11, 2023
@torchiaf torchiaf changed the title Avoid close Export Applications modal when clicking outside Export Applications modal, enhancements Aug 11, 2023
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@richard-cox richard-cox added this to the v1.10.0 milestone Aug 17, 2023
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some strangeness after Canceling the modal and trying again

  • The cancel side looks like it works fine
  • Trying to download the image again though results in a failure and a bad error message in a banner

image

  • The correct error should be presented to the user
  • There should be a BE ticket to ensure that the job creating the exported image is cancelled if the http request is cancelled export of app image requests can be concurrent

With those two things addressed we're good to merge this

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf
Copy link
Contributor Author

torchiaf commented Aug 17, 2023

  • The correct error should be presented to the user

I think the error is no more reproducible after refreshing my environment with latest main I reproduced the issue in the latest version of Epinio;
Not related to this issue: I realized we didn't handle esc button, just pushed a fix for this.

I just created a new issue to take note of the export error: epinio/epinio#2516 and pushed a change to handle the error messages on the UI.

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf merged commit 04a06c6 into epinio:main Aug 21, 2023
3 checks passed
@richard-cox richard-cox added the kind/enhancement New feature or request label Sep 4, 2023
@richard-cox richard-cox changed the title Export Applications modal, enhancements Improve Export Applications modal Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Applications modal, enhancements
2 participants