Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove downloads from {covidregionaldata} in R files #58

Merged
merged 8 commits into from
Jul 26, 2023

Conversation

pratikunterwegs
Copy link
Collaborator

@pratikunterwegs pratikunterwegs commented Jul 26, 2023

This PR is a WIP on issue #51, and removes data download steps in the function examples and tests. This reduces the time taken for checks to run when internet connections are slow, and works towards reducing the dependency on {covidregionaldata}.

The use of {covidregionaldata} in the vignettes is further reduced in PR #55, but not entirely avoided, pending the outcome of an ongoing discussion: https://github.com/orgs/epiverse-trace/discussions/85

@pratikunterwegs pratikunterwegs self-assigned this Jul 26, 2023
@pratikunterwegs pratikunterwegs marked this pull request as ready for review July 26, 2023 13:22
Copy link
Collaborator Author

@pratikunterwegs pratikunterwegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this as there are only minimal changes overall.

@pratikunterwegs pratikunterwegs merged commit 31e0eff into main Jul 26, 2023
8 checks passed
@pratikunterwegs pratikunterwegs deleted the dev/remove-downloads branch July 26, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant