Fix string matching for method assessment in new_epiparameter()
#401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the overwriting of
$method_assessin thenew_epiparameter()function when it is not a delay distribution, currently these would be either an offspring distribution or a case fatality risk. It was pointed out in the full package review (#394) that the previous use of==was error-prone and didn't match the current requirements in the parameter database (i.e. white space separated words).epiparameter_db()has been updated to work with<epiparameter>objects that do not have a list for$method_assessbut have a character string.The
sysdata.rdais updated.