…ut of date

thus taking advantage of config options

and datacite_core.pl code too

plus use of new config options

better name handling, use of new config etc

Added config param to check for DataCiteXML shcema version #2 #3 (Ideally the event will ask which schema version datacite will use, but for now we can set it in the config)

Updating the schema version to 4.0

… export

…f DataCite 4.0 metadata schema

…opy tabs

…oses #9

…corresponding sub is found in zzz_datacite_mapping

Thanks Borys

…the rightsList get appneded twice

Fixing a couple of typos in the readme.

Correct typos in Readme

Noticed this from the README, minor change

Our instance had its licence typename but no licence URI. As a result, the
following text was being output on every run of the plugin.

```
Undefined phrase: licenses_uri_cc_example (en) at line 238 in (eval 200)
anything really
```

This problem also bled directly in to the generated XML with error text where
our link should be.

```
<rightsList>
	<rights rightsURI="[&quot;licenses_uri_cc_example&quot; not defined]">University of Tasmania Standard License</rights>
</rightsList>
```

I've changed the file paths to be quoted so they stand out and wrapped the
descriptive text on to the same line to improve flow.

All paths now start with lib/ (taking / from two of them) as its likely someone
copying these will want the relative nature of the paths preserved.

Lastly the schema version for DataCite has been updated, looks like it was
missed in the commits which changed the schema -
d7f8a91 and
aceb640 .

Update DataCite test endpoint in line with their documentation.

Thanks to @liamgh for the contribution.

Our environment "doi" is not our field name so instead query our configuration
for the correct field to use.

…atory fields

…h that of

the actual configuration file.

Not everyone who can edit should necesarily be allowed to coin a DOI.

With this change the permission/role specifying who can mint becomes
configurable with its default value being the current setting.

This configuration option allows for altering which types of eprints will
display a 'Coin DOI' button on their administration page.

We are currently using this functionality so can attest to it having some use
testing.

This updates the URL associated with the schema in z_datacitedoi.pl.
The changes happend in 3.0 but 4.1 appears to have the same list as
3.0 was released with.

Minor changes, just a collection of issues I noticed while reading through the
plugin.

Rework hostname check as validation sub routine

Based on feedback in #31 I've merged my existing code in to the new 2.1
branch's validate_datacite function.

There are a couple of minor updates too:
* Update path to validate_datacite ; validate_datacite lives in the mapping file under lib/cfg.d rather than the main configuration file in cfg/cfg.d.
* Copy / paste fix in a comment
* Now using get_conf instead of $c->

As reported in #14, Crypt::SSLeay is no longer the recommended way of getting
HTTPS through LWP.

https://wiki.eprints.org/w/index.php?title=Installing_EPrints_on_RHEL/Fedora/CentOS&diff=prev&oldid=12408

This is also backed up by Crypt::SSLeay upstream who warn
```
At this point, Crypt::SSLeay is maintained to support existing software that
already depends on it. However, it is possible that your software does not
really depend on Crypt::SSLeay, only on the ability of LWP::UserAgent class to
communicate with sites over SSL/TLS.
```

https://metacpan.org/pod/Crypt::SSLeay#DO-YOU-NEED-Crypt::SSLeay?

Closes: #14
Closes: #23

If a document has no 'content' value $content will be empty and the
condition will generate a warning.

I attempted to include this in the original version of the changes but couldn't
get it working until I stumbled upon
https://wiki.eprints.org/w/index.php?title=My_First_Bazaar_Package and its
example Hello.pm.

Message now includes the matched regex and doi prefix in the error message,
bolded for readability.

"Text15" appears to have been copied verbaitum from
DataCite-MetadataKernel_v4.0.pdf , where "Text" appears with superscript "15"
to indicate a footnote.

For anyone playing along at home, in v4.1 the relevant footnote is 18.

Offer WWW::Curl as an option for API connections

The cause of this development was the age of LWP in RHEL6.10 can't handle SNI servers - used by DataCite for their API.

For more on the LWP age issue and curl updates which ensure it works see these issues.
libwww-perl/LWP-Protocol-https#17 LWP SNI fix from 6.07
curl/curl#700 - Curl updates in RHEL 6.7 and 6.8

This branch/change allows curl to be used opt in, defaulting to LWP, and should not change any existing behaviours (those breaking changes were in #23 and #33).

There are also some other changes which have come through as I've tried to keep various files (like configuration and README) in sync.

Somehow this went missing during my merge, adding back in.

In #16 (specifically cbf2a2c) the codebase was
changed to forcibly add the "Default publisher" value to all submissions as it
wasn't being (reliably) added. In the rework for 2.1.0 (I'm looking at
fd41e34 but its other commits are relevant
too) the behaviour changed and now publisher is added if available.

This has resulted in the unfortunate situation that:
* If you have no publisher, none is added
* If you do have a publisher, a second is added

Not the situation we want:
* If you have no publisher, one is added
* If you have a publisher, nothing changes

Turns out the correct way to conditionally import - use - a module is to eval()
them. I've now set up all modules required by DataCiteEvent to eval() in and to
print a log message if something is missing.

This change allows diagnosing the XML supplied to DataCite by logging the
entire lot rather than just mentioning the DOI.

Authentication wise this should be safe to do, as the username and password are
not included directly in the XML.

This file needs to be regenerated in its entirity but I'm updating its version
field as I'm about to tag the release candidate.

Unlike other mapping functions, funders assumed that its values were available
and required. This change makes checking eprints for funder and project
information optional to better reflect the standard and to facilitate a switch
from eprint value based attributes to mapping based attributes.

In essense, this change removes the depencence on specific eprints fields
having values when performing the XML export.

This expands on the change in 336a27c
("reworked Export plugin so that *any* EPrint field can be mapped if
corresponding sub is found in zzz_datacite_mapping") and removes the change
required in f8a3259 becuase now we run all
maps.

It moves from an 'eprint first' configuration to a 'mapping function first'
which permits:
- Setting default values (like Publisher)
- Choosing the eprint fields data comes from (You have a custom date field? no worries).
- Adding new values to output XML by adding a new mapping function
- Basically, running arbitrary code. But don't do that.

Of course, anyone adding new mappings or overriding existing mappings will need
to handle the resulting validation problems themselves...

This is the export components work required to complete #35; optional changes
to validation would facilitiate the second part but validation can be done via
overrides per site.

Closes: #35

Firstly (in terms of execution order) is a change to the date validation to
make explicit the intent - that date and date type must be set and date type
must equal published.
I believe this also resolves a matching bug.

Secondly is a relaxing of the date requirements fro datacite_mapping_date to
stop checking date_type is published. If date type is was unset this would pass
validation then cause an error to be printed due to an empty value being used
in string equality testing.
Further tightening the check in datacite_mapping_date was a possibility but
since validation is run first it seems reasonable that datacite_mapping_date be
more trusting (and may even make things more flexibile for those who customise
their validation).

corp_creators is a multi value field but was being treated as a string; its now
looped and all corp_creators are added to <creators>.